Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Narrowing Http.send return type #225

Merged
merged 1 commit into from
Sep 6, 2023
Merged

Narrowing Http.send return type #225

merged 1 commit into from
Sep 6, 2023

Conversation

TonioGela
Copy link
Contributor

Fixes #224.

TonioGela
TonioGela commented Aug 30, 2023
View reviewed changes
tyrian/js/src/main/scala/tyrian/runtime/CmdHelper.scala
import scala.annotation.tailrec
import scala.collection.mutable.ListBuffer
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's worth saying that it was scalafmt that did this.

davesmith00000
davesmith00000 approved these changes Sep 6, 2023
View reviewed changes
Copy link
Member

@davesmith00000 davesmith00000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lovely, thank you - just catching up on PRs. I've kicked off a build, hopefully it'll pass and I'll merge it.

@davesmith00000 davesmith00000 merged commit dff9ed7 into PurpleKingdomGames:main Sep 6, 2023
1 check passed
@TonioGela TonioGela deleted the fix_send_signature branch September 7, 2023 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davesmith00000 davesmith00000 davesmith00000 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unable to effectfully create a Http.send command
2 participants
@TonioGela @davesmith00000