From 0cead8701f132670bd5618ceeb8fdee8e9a3ad27 Mon Sep 17 00:00:00 2001
From: Puru Vijay <47742487+PuruVJ@users.noreply.github.com>
Date: Sat, 7 Dec 2024 00:52:19 +0530
Subject: [PATCH] deprecate legacyTranslate and gpuAcceleration (#176)

* Push

* Add changeset
---
 .changeset/seven-schools-relax.md             | 10 +++++++
 docs/src/components/options/Options.astro     |  9 ++++---
 docs/src/data/sizes.json                      | 26 +++++++++----------
 .../options/gpuAcceleration/+option.mdx       |  2 ++
 .../options/legacyTranslate/+option.mdx       |  2 ++
 docs/src/layouts/DocsLayout.astro             | 12 ++++-----
 docs/src/layouts/MainDocsLayout.astro         | 12 ++++-----
 packages/core/src/index.ts                    | 13 ++++------
 8 files changed, 50 insertions(+), 36 deletions(-)
 create mode 100644 .changeset/seven-schools-relax.md

diff --git a/.changeset/seven-schools-relax.md b/.changeset/seven-schools-relax.md
new file mode 100644
index 000000000..021c92400
--- /dev/null
+++ b/.changeset/seven-schools-relax.md
@@ -0,0 +1,10 @@
+---
+"@neodrag/core": minor
+"@neodrag/react": minor
+"@neodrag/solid": minor
+"@neodrag/svelte": minor
+"@neodrag/vanilla": minor
+"@neodrag/vue": minor
+---
+
+deprecate: legacyTranslate and gpuAcceleration
diff --git a/docs/src/components/options/Options.astro b/docs/src/components/options/Options.astro
index e615a8904..3ef9e5e11 100644
--- a/docs/src/components/options/Options.astro
+++ b/docs/src/components/options/Options.astro
@@ -70,7 +70,10 @@ const orderedOptionsMD = ORDER.map(
 <section class='options-examples container'>
 	{
 		orderedOptionsMD.map(
-			({ Content, frontmatter: { defaultValue, title, type } }) => (
+			({
+				Content,
+				frontmatter: { defaultValue, title, type, deprecated, deprecatedText },
+			}) => (
 				<>
 					<h3 id={slugify(title)}>
 						{title}
@@ -82,8 +85,6 @@ const orderedOptionsMD = ORDER.map(
 							href={`#${slugify(title)}`}
 						>
 							<PhLinkThin
-								{
-								/* @ts-ignore */ }
 								style='color: var(--app-color-dark)'
 								width='1em'
 								height='1em'
@@ -91,6 +92,8 @@ const orderedOptionsMD = ORDER.map(
 						</a>
 					</h3>
 					<p>
+						{deprecated === true ? `⚠️ Deprecated: ${deprecatedText}` : ''}
+						<br />
 						Type:
 						<span class='code-like' style='font-family: var(--app-font-mono)'>
 							{type}
diff --git a/docs/src/data/sizes.json b/docs/src/data/sizes.json
index 528dec727..3646f24b9 100644
--- a/docs/src/data/sizes.json
+++ b/docs/src/data/sizes.json
@@ -1,22 +1,22 @@
 {
-  "react": {
-    "size": "2.20",
-    "version": "2.0.4"
-  },
   "svelte": {
     "size": "1.97",
-    "version": "2.0.6"
+    "version": "2.1.0"
   },
-  "solid": {
-    "size": "1.99",
-    "version": "2.0.4"
+  "react": {
+    "size": "2.21",
+    "version": "2.1.0"
+  },
+  "vanilla": {
+    "size": "2.00",
+    "version": "2.1.0"
   },
   "vue": {
-    "size": "1.99",
-    "version": "2.0.4"
+    "size": "2.00",
+    "version": "2.1.0"
   },
-  "vanilla": {
-    "size": "2.01",
-    "version": "2.0.5"
+  "solid": {
+    "size": "2.00",
+    "version": "2.1.0"
   }
 }
\ No newline at end of file
diff --git a/docs/src/documentation/options/gpuAcceleration/+option.mdx b/docs/src/documentation/options/gpuAcceleration/+option.mdx
index 17b6fe10a..fb6787e6a 100644
--- a/docs/src/documentation/options/gpuAcceleration/+option.mdx
+++ b/docs/src/documentation/options/gpuAcceleration/+option.mdx
@@ -2,6 +2,8 @@
 title: 'gpuAcceleration'
 type: 'boolean'
 defaultValue: 'true'
+deprecated: true
+deprecatedText: 'Will be removed in v3'
 ---
 
 import Code from '$components/options/OptionsCode.astro';
diff --git a/docs/src/documentation/options/legacyTranslate/+option.mdx b/docs/src/documentation/options/legacyTranslate/+option.mdx
index 056e14d5d..5c7fca096 100644
--- a/docs/src/documentation/options/legacyTranslate/+option.mdx
+++ b/docs/src/documentation/options/legacyTranslate/+option.mdx
@@ -2,6 +2,8 @@
 title: legacyTranslate
 type: 'boolean'
 defaultValue: 'true'
+deprecated: true
+deprecatedText: 'Will be removed in v3'
 ---
 
 import Code from '$components/options/OptionsCode.astro';
diff --git a/docs/src/layouts/DocsLayout.astro b/docs/src/layouts/DocsLayout.astro
index 6f0fe3dcd..a1db2c189 100644
--- a/docs/src/layouts/DocsLayout.astro
+++ b/docs/src/layouts/DocsLayout.astro
@@ -21,13 +21,13 @@ const { title: frontmatterTitle } = frontmatter || {};
 
 <Layout title={title ?? frontmatterTitle}>
 	<ToC client:only />
-	<div class="mobile-nav">
-		<MobileNav client:media="(max-width: 968px)" />
+	<div class='mobile-nav'>
+		<MobileNav client:media='(max-width: 968px)' />
 	</div>
 
-	<section class="docs-container" id="docs-container">
+	<section class='docs-container' id='docs-container'>
 		<aside>
-			<Nav client:media="(min-width: 969px)" client:load />
+			<Nav client:media='(min-width: 969px)' client:load />
 		</aside>
 
 		<main>
@@ -38,7 +38,7 @@ const { title: frontmatterTitle } = frontmatter || {};
 	</section>
 </Layout>
 
-<style lang="scss">
+<style lang='scss'>
 	@import '../css/breakpoints';
 
 	.mobile-nav {
@@ -146,7 +146,7 @@ const { title: frontmatterTitle } = frontmatter || {};
 	}
 </style>
 
-<style lang="scss" is:global>
+<style lang='scss' is:global>
 	@import '../css/breakpoints';
 
 	:root {
diff --git a/docs/src/layouts/MainDocsLayout.astro b/docs/src/layouts/MainDocsLayout.astro
index ee8d962df..015036191 100644
--- a/docs/src/layouts/MainDocsLayout.astro
+++ b/docs/src/layouts/MainDocsLayout.astro
@@ -25,12 +25,12 @@ const { size, version } = SIZES[framework];
 		>
 	</h1>
 
-	<div class="tags">
-		<span class="tag">
+	<div class='tags'>
+		<span class='tag'>
 			{version}
 		</span>
 
-		<span class="tag">
+		<span class='tag'>
 			{size}KB
 		</span>
 	</div>
@@ -42,14 +42,14 @@ const { size, version } = SIZES[framework];
 	<h2>Credits</h2>
 	<p>
 		Inspired from the amazing
-		<a href="https://github.com/react-grid-layout/react-draggable">
+		<a href='https://github.com/react-grid-layout/react-draggable'>
 			react-draggable
 		</a>
-		 library, and implements the same API.
+		library, and implements the same API.
 	</p>
 </DocsLayout>
 
-<style lang="scss">
+<style lang='scss'>
 	.tags {
 		display: flex;
 		flex-wrap: wrap;
diff --git a/packages/core/src/index.ts b/packages/core/src/index.ts
index 4b5da3211..0ad7f6d5f 100644
--- a/packages/core/src/index.ts
+++ b/packages/core/src/index.ts
@@ -82,7 +82,8 @@ export type DragOptions = {
 	 *
 	 * At present this is true by default, but will be changed to false in a future major version.
 	 *
-	 * @default true
+	 * @default false
+	 * @deprecated Use `transform` option instead for transform: translate() or any other custom transform. Will be removed in v3.
 	 */
 	legacyTranslate?: boolean;
 
@@ -92,6 +93,7 @@ export type DragOptions = {
 	 * `true` by default, but can be set to `false` if [blurry text issue](https://developpaper.com/question/why-does-the-use-of-css3-translate3d-result-in-blurred-display/) occur
 	 *
 	 * @default true
+	 * @deprecated Use `transform` option instead with translate(x, y, 1px). 1px forces some browsers to use GPU acceleration. Will be removed in v3
 	 */
 	gpuAcceleration?: boolean;
 
@@ -272,7 +274,7 @@ export function draggable(node: HTMLElement, options: DragOptions = {}) {
 		bounds,
 		axis = 'both',
 		gpuAcceleration = true,
-		legacyTranslate = true,
+		legacyTranslate = false,
 		transform,
 		applyUserSelectHack = true,
 		disabled = false,
@@ -335,7 +337,6 @@ export function draggable(node: HTMLElement, options: DragOptions = {}) {
 	// Set proper defaults for recomputeBounds
 	recomputeBounds = { ...DEFAULT_RECOMPUTE_BOUNDS, ...recomputeBounds };
 
-	console.log(threshold);
 	// Proper defaults for threshold
 	threshold = { ...DEFAULT_DRAG_THRESHOLD, ...(threshold ?? {}) };
 
@@ -382,11 +383,7 @@ export function draggable(node: HTMLElement, options: DragOptions = {}) {
 				);
 			}
 
-			return set_style(
-				node,
-				'translate',
-				`${+x_pos}px ${+y_pos}px ${gpuAcceleration ? '1px' : ''}`,
-			);
+			return set_style(node, 'translate', `${+x_pos}px ${+y_pos}px`);
 		}
 
 		// Call transform function if provided