Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove check for # noqa comments #134

Merged
merged 2 commits into from
Oct 19, 2020
Merged

Remove check for # noqa comments #134

merged 2 commits into from
Oct 19, 2020

Conversation

plinss
Copy link
Contributor

@plinss plinss commented Aug 28, 2020

Fixes #44

cooperlees
cooperlees requested changes Aug 28, 2020
View reviewed changes
Copy link
Collaborator

@cooperlees cooperlees left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to modify the config CI uses now in order to ignore what we use to?

@cooperlees
Copy link
Collaborator

Here? https://github.com/PyCQA/flake8-bugbear/blob/master/.flake8#L5

@plinss
Copy link
Contributor Author

plinss commented Aug 28, 2020

I don't think so, but it does look like I need to update some tests (was having trouble running the tests locally).

It looks like some tests are checking for the # noqa comments working when calling the BugBearChecker directly.

@cooperlees cooperlees requested a review from ambv August 29, 2020 00:28
cooperlees
cooperlees approved these changes Oct 18, 2020
View reviewed changes
Copy link
Collaborator

@cooperlees cooperlees left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All makes sense to me with the explanation.

@cooperlees cooperlees merged commit b70d712 into PyCQA:master Oct 19, 2020
This was referenced Mar 9, 2021
Merged
Merged
Merged
Closed
Closed
Merged
Merged
Closed
@dependabot dependabot bot mentioned this pull request Mar 16, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cooperlees cooperlees cooperlees approved these changes

@ambv ambv Awaiting requested review from ambv

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ignores all errors when using noqa: X to only ignore X
2 participants
@plinss @cooperlees