Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: scm versioning #10

Merged
merged 5 commits into from
Jan 16, 2023
Merged

feat: scm versioning #10

merged 5 commits into from
Jan 16, 2023

Conversation

cako
Copy link
Collaborator

@cako cako commented Jan 15, 2023

Closes #9

@cako cako requested a review from mrava87 January 15, 2023 22:21
mrava87
mrava87 reviewed Jan 16, 2023
View reviewed changes
Copy link
Contributor

@mrava87 mrava87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I only checked the scm related changes and they look correct to me :)

I leave it to you to merge when you are done with the other code changes.

@cako cako merged commit 14a9b5d into main Jan 16, 2023
@cako cako deleted the patch-setuptools_scm branch January 16, 2023 05:46
cako added a commit that referenced this pull request Jan 22, 2023
@cako
feat: scm versioning (#10)
633d317 
* feat: scm versioning

* fix: remove old versions

* fix: update copyright
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrava87 mrava87 mrava87 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Versioning with setuptools_scm
2 participants
@cako @mrava87