rMS proximal operator #142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrava87
reviewed
Oct 9, 2023
There was a problem hiding this comment.
@NickLuiken thanks for adding this, looks great.
I made some changes and also added a few comments where I was unsure. Please either reply here and I can fix it, or make sure to git pull origin dev before making the changes and pushing them to avoid conflicts with my changes
pyproximal/proximal/rMS.py
Outdated
| x : :obj:`numpy.ndarray` | ||
| Vector | ||
| thresh : :obj:`float` | ||
| Threshold |
There was a problem hiding this comment.
No, it is a regularization parameter and I changed the docstring
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request for the rMS proximal operator and the rMS tutorial