-
-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Action doesn't work when using trusted publishers #321
Comments
I'm blind, it was right there. I have something else causing this failure. |
Actually, this is the issue: Maturin checks if GITHUB_ACTIONS is set, and it is not set from what I see:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I did some digging and the reason behind it is that trusted publisher code relies on some environment variables that start with
ACTIONS_
, such as:ACTIONS_ID_TOKEN_REQUEST_URL
.Since those are not in the list here:
https://github.com/PyO3/maturin-action/blob/main/src/index.ts#L232-L251
It's not passing it down to Maturin:
https://github.com/PyO3/maturin/blob/865f965e088bd4433d9832defb1706b3456b492e/src/upload.rs#L270-L273
I'll push up a PR in a second.
The text was updated successfully, but these errors were encountered: