Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Trove classifiers #32

Closed
ijl opened this issue Nov 22, 2018 · 2 comments
Closed

Trove classifiers #32

ijl opened this issue Nov 22, 2018 · 2 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@ijl
Copy link
Contributor

ijl commented Nov 22, 2018

Thoughts on adding support for trove classifiers for pypi?

Possibly something like:

[package.metadata.pyo3-pack.metadata]
classifier = [
    "Programming Language :: Python",
    "Programming Language :: Python :: 3",
    "Programming Language :: Python :: 3.7",
]

This is somewhat consistent with the [package.metadata.pyo3-pack.scripts] mentioned in the README.
@konstin
Copy link
Member

konstin commented Nov 24, 2018

I'd like that!

@konstin konstin added the enhancement New feature or request label Nov 24, 2018
@konstin
Copy link
Member

konstin commented Dec 5, 2018

This should be really easy to implement. Just parse a classifier key (type Vec<String> from [package.metadata.pyo3-pack], similar to scripts is currently parsed, and fill the relevant Metadata21 field:

https://github.com/PyO3/pyo3-pack/blob/eeaa4b4d4a40c7551fd94123a037e92a3998eed3/src/metadata.rs#L46

@konstin konstin added the good first issue Good for newcomers label Dec 5, 2018
@ijl ijl mentioned this issue Dec 14, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ijl @konstin