Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

maturin examples #807

Closed
kngwyu opened this issue Mar 13, 2020 · 3 comments · Fixed by #1537
Closed

maturin examples #807

kngwyu opened this issue Mar 13, 2020 · 3 comments · Fixed by #1537
Assignees

Comments

@kngwyu
Copy link
Member

kngwyu commented Mar 13, 2020

Now our examples are built by setuptools-rust, but since currently maturin is (maybe more) widely used, we should also provide maturin examples.

@davidhewitt
Copy link
Member

As I'm working on the experimental maturin support for #1040 I'm going to convert the existing examples to maturin soon, probably this week.

I'll add a new minimalist example showing setuptools-rust configuration.

@davidhewitt davidhewitt self-assigned this Jul 19, 2020
@konstin
Copy link
Member

konstin commented Jul 22, 2020

You should be able to just leave the setuptools part in since maturin simply ignores those files, so that the setuptools fans still get an example.

@davidhewitt
Copy link
Member

Having started playing around with this, I found that it's nicer to make separate maturin and setuptools-rust examples because then it's easier for users to see what configuration is needed depending on the packaging tool they chose.

I ran into a bit of a speedbump with the tox testing of the maturin example. You've seen already the PRs I put into tox and maturin to resolve this, though I still have issues because the PEP 517 out-of-tree build fails because the pyo3 path = "../../" obviously doesn't get found when building in a temporary directory.

I'm trying to decide if I should hack in a wrapper around maturin as a PEP 517 "inline backend" to solve this issue, or whether to give up and just test the setuptools-rust bit using tox.

Hopefully I can find some time to have another go at finishing this off soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants