Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test_dataloaders to test method #1434

Merged
merged 7 commits into from
Apr 10, 2020
Merged

Add test_dataloaders to test method #1434

merged 7 commits into from
Apr 10, 2020

Conversation

rohitgr7
Copy link
Contributor

@rohitgr7 rohitgr7 commented Apr 9, 2020 •
edited
Loading

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

What does this PR do?

Fixes #1393.

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@pep8speaks
Copy link

pep8speaks commented Apr 9, 2020 •
edited
Loading

Hello @rohitgr7! Thanks for updating this PR.

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2020-04-09 23:21:49 UTC

@mergify mergify bot requested a review from a team April 9, 2020 18:42
@mergify mergify bot requested a review from a team April 9, 2020 18:46
Borda
Borda reviewed Apr 9, 2020
View reviewed changes
Copy link
Member

@Borda Borda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also add note to changelog...

@mergify mergify bot requested a review from a team April 9, 2020 21:10
@Borda
Copy link
Member

Borda commented Apr 9, 2020

@rohitgr7 may you check the falling tests?

@Borda Borda added the feature Is an improvement or enhancement label Apr 10, 2020
@williamFalcon williamFalcon merged commit e79ae18 into Lightning-AI:master Apr 10, 2020
@Borda Borda added this to the 0.7.3 milestone Apr 10, 2020
@yukw777 yukw777 mentioned this pull request Apr 15, 2020
Closed
@rohitgr7 rohitgr7 deleted the add_test_dl branch April 26, 2020 11:29
tullie pushed a commit to tullie/pytorch-lightning that referenced this pull request Jun 7, 2020
@rohitgr7 @tullie
Add test_dataloaders to test method (Lightning-AI#1434)
b8c30ff 
* Add test_dataloaders to test method

* Remove test_dataloaders from .fit()

* Fix code comment

* Fix tests

* Add test_dataloaders to test method (Lightning-AI#1393)

* Fix failing tests

* Update docs (Lightning-AI#1393)
@Borda Borda modified the milestones: 0.7.3, v0.7.x Apr 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Borda Borda Borda left review comments

@williamFalcon williamFalcon williamFalcon left review comments

Assignees
No one assigned
Labels
feature Is an improvement or enhancement
Projects
None yet
Milestone
pl:0.7.x
Development

Successfully merging this pull request may close these issues.

Add dataloader arg to Trainer.test()
4 participants
@rohitgr7 @pep8speaks @Borda @williamFalcon