-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Also update progress_bar in training_epoch_end #1724
Merged
williamFalcon
merged 7 commits into
Lightning-AI:master
from
awaelchli:feature/pbar_metrics_epoch
May 9, 2020
Merged
Also update progress_bar in training_epoch_end #1724
williamFalcon
merged 7 commits into
Lightning-AI:master
from
awaelchli:feature/pbar_metrics_epoch
May 9, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1724 +/- ##
======================================
Coverage 88% 88%
======================================
Files 69 69
Lines 4156 4157 +1
======================================
+ Hits 3666 3668 +2
+ Misses 490 489 -1 |
Hello @awaelchli! Thanks for updating this PR. There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2020-05-07 21:49:09 UTC |
awaelchli
changed the title
[WIP] Also update progress_bar in training_epoch_end
Also update progress_bar in training_epoch_end
May 6, 2020
Borda
approved these changes
May 7, 2020
jeremyjordan
approved these changes
May 8, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
always good to add better test coverage :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting
What does this PR do?
Fixes #1448.
I noticed we don't have thorough testing for the LightningModule methods. We should test that the outputs of these methods and hooks get correctly passed to the trainer. Therefore I added a module subdirectory. One file per method, i.e., training_step, training_epoch_end, ...
What do you think?
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃