Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[metrics] IoU Metric #2062

Merged
merged 11 commits into from
Jun 18, 2020
Merged

[metrics] IoU Metric #2062

merged 11 commits into from
Jun 18, 2020

Conversation

j-dsouza
Copy link
Contributor

@j-dsouza j-dsouza commented Jun 3, 2020 •
edited
Loading

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

What does this PR do?

Adds feature, fixes #1299

WIP:

  • IoU metric class to be added
  • Documentation to be added

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@pep8speaks
Copy link

pep8speaks commented Jun 3, 2020 •
edited
Loading

Hello @j-dsouza! Thanks for updating this PR.

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2020-06-18 12:36:52 UTC

@mergify mergify bot requested a review from a team June 3, 2020 16:02
justusschock
justusschock requested changes Jun 4, 2020
View reviewed changes
Copy link
Member

@justusschock justusschock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some comments

pytorch_lightning/metrics/functional/classification.py Outdated Show resolved Hide resolved
tests/metrics/functional/test_classification.py Show resolved Hide resolved
pytorch_lightning/metrics/functional/classification.py Outdated Show resolved Hide resolved
@mergify mergify bot requested a review from a team June 4, 2020 14:50
@j-dsouza j-dsouza changed the title [WIP] Feature/1299 iou metric [WIP] IoU Metric Jun 4, 2020
@Borda Borda force-pushed the native_torch_metrics branch 2 times, most recently from 4d1eb4c to 18b7e24 Compare June 9, 2020 14:41
@Borda Borda added the feature Is an improvement or enhancement label Jun 9, 2020
@Borda
Copy link
Member

Borda commented Jun 9, 2020

@j-dsouza @justusschock how is it going here? maybe set master as a target? 🐰

@Borda Borda added this to the 0.8.x milestone Jun 9, 2020
@justusschock
Copy link
Member

This should be ready, once #1488 is done. We cannot yet set master as target, since this depends on some functions of #1488

@Borda Borda force-pushed the native_torch_metrics branch from 18b7e24 to b605b2d Compare June 10, 2020 13:50
@Borda Borda changed the title [WIP] IoU Metric [blocked by #1488] IoU Metric Jun 10, 2020
@Borda Borda force-pushed the native_torch_metrics branch from 5fbb86a to f672ab6 Compare June 12, 2020 15:37
@Borda Borda closed this Jun 13, 2020
@justusschock
Copy link
Member

@Borda why close this? This is not included by #1488 but depends on it

@Borda
Copy link
Member

Borda commented Jun 13, 2020

it was some automation from GH, can we reopen it?

@Borda Borda reopened this Jun 13, 2020
@Borda Borda changed the base branch from native_torch_metrics to master June 13, 2020 16:21
@Borda Borda changed the title [blocked by #1488] IoU Metric IoU Metric Jun 13, 2020
@Borda Borda force-pushed the feature/1299_iou_metric branch from 85acf42 to c863ab7 Compare June 13, 2020 16:29
justusschock
justusschock approved these changes Jun 18, 2020
View reviewed changes
Copy link
Member

@justusschock justusschock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mergify mergify bot requested a review from a team June 18, 2020 08:51
@Borda Borda force-pushed the feature/1299_iou_metric branch from 1b6d9fa to d814fab Compare June 18, 2020 08:55
Borda
Borda requested changes Jun 18, 2020
View reviewed changes
Copy link
Member

@Borda Borda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pls add tests...

pytorch_lightning/metrics/classification.py Outdated Show resolved Hide resolved
pytorch_lightning/metrics/classification.py
class IoU(TensorMetric):
"""
Computes the intersection over union.
"""
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add doctest example

tests/metrics/functional/test_classification.py Outdated Show resolved Hide resolved
tests/metrics/test_classification.py Show resolved Hide resolved
@mergify mergify bot requested a review from a team June 18, 2020 09:02
@codecov
Copy link

codecov bot commented Jun 18, 2020 •
edited
Loading

Codecov Report

Merging #2062 into master will increase coverage by 0%.
The diff coverage is 100%.

@@          Coverage Diff           @@
##           master   #2062   +/-   ##
======================================
  Coverage      88%     88%           
======================================
  Files          70      70           
  Lines        5420    5436   +16     
======================================
+ Hits         4760    4776   +16     
  Misses        660     660

@mergify
Copy link
Contributor

mergify bot commented Jun 18, 2020

This pull request is now in conflict... :(

@Borda Borda force-pushed the feature/1299_iou_metric branch from f50d991 to 95f9b5f Compare June 18, 2020 11:56
@mergify mergify bot requested a review from a team June 18, 2020 12:15
@Borda Borda self-assigned this Jun 18, 2020
@edenlightning edenlightning changed the title IoU Metric [metrics] IoU Metric Jun 18, 2020
@mergify mergify bot requested a review from a team June 18, 2020 12:40
@williamFalcon williamFalcon merged commit e0b7359 into Lightning-AI:master Jun 18, 2020
@Borda
Copy link
Member

Borda commented Jun 18, 2020

@j-dsouza great work!

@Borda Borda modified the milestones: 0.8.x, 0.8.0 Jun 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justusschock justusschock justusschock approved these changes

@Borda Borda Borda approved these changes

@awaelchli awaelchli Awaiting requested review from awaelchli

@jeremyjordan jeremyjordan Awaiting requested review from jeremyjordan

@MattPainter01 MattPainter01 Awaiting requested review from MattPainter01

@neggert neggert Awaiting requested review from neggert

Assignees

@Borda Borda

@justusschock justusschock

Labels
feature Is an improvement or enhancement
Projects
None yet
Milestone
pl:0.8
Development

Successfully merging this pull request may close these issues.

[Metrics] IOU
5 participants
@j-dsouza @pep8speaks @Borda @justusschock @williamFalcon