Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix summary hook handles not getting removed #2298

Merged
merged 6 commits into from
Jun 20, 2020
Merged

Fix summary hook handles not getting removed #2298

merged 6 commits into from
Jun 20, 2020

Conversation

awaelchli
Copy link
Contributor

@awaelchli awaelchli commented Jun 20, 2020

What does this PR do?

Fixes #2281
Forward hooks that are installed are supposed to remove themselves after running once.
However, if the model has layers that are unused, the hooks don't get removed, which causes the bug.

I made sure the test alone fails on master.

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together? Otherwise, we ask you create a separate PR for every change.
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests?
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@awaelchli awaelchli added the bug Something isn't working label Jun 20, 2020
@mergify mergify bot requested a review from a team June 20, 2020 08:44
@awaelchli awaelchli marked this pull request as ready for review June 20, 2020 09:02
@williamFalcon williamFalcon merged commit f972ab3 into Lightning-AI:master Jun 20, 2020
@awaelchli awaelchli deleted the bugfix/summary_hook_handles branch June 20, 2020 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RuntimeError: OrderedDict mutated during iteration
2 participants