Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #1916.
Essentially this PR will make
parse_argparser
properly do the inverse of whatadd_argparse_args
does.The reason for the issue is that PL auto-generates an argparser that accepts flag style options, i.e.
--auto_lr_find
leads toargs.auto_lr_find is True
. The only way to provide a negative flag (for options that default toTrue
) is to use--auto_lr_find False
. Because some parameters (likeauto_lr_find
) can be both a boolean and a string, the generated parser for these arguments usesnargs="?"
, which means that the default value becomesNone
, regardless of the default value in__init__
. This means that for the flag-style options,parse_argparser
needs to convert some of theNone
values to booleans.Not sure if I should format with black or not, as that would create a large diff that is unrelated to the changes needed for the issue.
Also I think the argparse solution is not very robust. This PR simply fixes the immediate issue, but I think it is quite likely that something similar could happen again.
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃