-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing methods to logger collection #2723
Add missing methods to logger collection #2723
Conversation
This pull request is now in conflict... :( |
@ethanwharris mind rebase on fixed master... 🐰 |
Codecov Report
@@ Coverage Diff @@
## master #2723 +/- ##
======================================
- Coverage 90% 90% -0%
======================================
Files 82 82
Lines 6813 6805 -8
======================================
- Hits 6164 6144 -20
- Misses 649 661 +12 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good fix!
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 😄
What does this PR do?
Fixes #1547
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃