Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing methods to logger collection #2723

Merged
merged 6 commits into from
Jul 29, 2020

Conversation

ethanwharris
Copy link
Member

@ethanwharris ethanwharris commented Jul 27, 2020

What does this PR do?

Fixes #1547

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together? Otherwise, we ask you to create a separate PR for every change.
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests?
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@mergify mergify bot requested a review from a team July 27, 2020 14:13
@mergify
Copy link
Contributor

mergify bot commented Jul 27, 2020

This pull request is now in conflict... :(

@Borda
Copy link
Member

Borda commented Jul 28, 2020

@ethanwharris mind rebase on fixed master... 🐰

@ethanwharris ethanwharris added the bug Something isn't working label Jul 28, 2020
@codecov
Copy link

codecov bot commented Jul 28, 2020

Codecov Report

Merging #2723 into master will decrease coverage by 0%.
The diff coverage is 100%.

@@          Coverage Diff           @@
##           master   #2723   +/-   ##
======================================
- Coverage      90%     90%   -0%     
======================================
  Files          82      82           
  Lines        6813    6805    -8     
======================================
- Hits         6164    6144   -20     
- Misses        649     661   +12     

Copy link
Contributor

@awaelchli awaelchli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good fix!

pytorch_lightning/loggers/base.py Outdated Show resolved Hide resolved
@mergify mergify bot requested a review from a team July 29, 2020 01:13
CHANGELOG.md Outdated Show resolved Hide resolved
@mergify mergify bot requested a review from a team July 29, 2020 06:50
ethanwharris and others added 2 commits July 29, 2020 10:41
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
@Borda Borda added allowed_pre_1.0 ready PRs ready to be merged labels Jul 29, 2020
Copy link
Contributor

@nateraw nateraw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 😄

@Borda Borda merged commit 458d3e2 into Lightning-AI:master Jul 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Metric aggragation is broken for LoggerCollection
4 participants