Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update training_tricks.py #3151

Merged
merged 4 commits into from
Aug 26, 2020
Merged

Update training_tricks.py #3151

merged 4 commits into from
Aug 26, 2020

Conversation

LeeJZh
Copy link
Contributor

@LeeJZh LeeJZh commented Aug 25, 2020

What does this PR do?

reset auto_lr_find so that it would not be called during batch size search

Fixes #3088

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together? Otherwise, we ask you to create a separate PR for every change.
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests?
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@pep8speaks
Copy link

pep8speaks commented Aug 25, 2020

Hello @LeeJZh! Thanks for updating this PR.

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2020-08-26 07:06:19 UTC

@mergify mergify bot requested a review from a team August 25, 2020 10:39
@Borda Borda added the bug Something isn't working label Aug 25, 2020
@Borda Borda added this to the 0.9.x milestone Aug 25, 2020
@Borda Borda added the ready PRs ready to be merged label Aug 25, 2020
@mergify mergify bot requested a review from a team August 25, 2020 10:49
@codecov
Copy link

codecov bot commented Aug 25, 2020

Codecov Report

Merging #3151 into master will decrease coverage by 4%.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master   #3151    +/-   ##
=======================================
- Coverage      90%     85%    -4%     
=======================================
  Files          84      84            
  Lines        8008    7990    -18     
=======================================
- Hits         7186    6820   -366     
- Misses        822    1170   +348     

@mergify mergify bot requested a review from a team August 25, 2020 11:05
@mergify mergify bot requested a review from a team August 25, 2020 16:55
@mergify
Copy link
Contributor

mergify bot commented Aug 25, 2020

Great job! =)

@mergify
Copy link
Contributor

mergify bot commented Aug 26, 2020

Great job! =)

@mergify mergify bot merged commit 0112355 into Lightning-AI:master Aug 26, 2020
@mergify
Copy link
Contributor

mergify bot commented Aug 26, 2020

Great job! =)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When auto_sceale_batch_size and auto_lr_find are both enabled, lr find is called with every batch search
5 participants