-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
limit auto scaling batch size to the size of the training dataset #3271
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3271 +/- ##
======================================
Coverage 90% 90%
======================================
Files 98 98
Lines 8069 8072 +3
======================================
+ Hits 7279 7282 +3
Misses 790 790 |
This pull request is now in conflict... :( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
00e73c1
to
2e0218c
Compare
@awaelchli maybe I made a mistake in rebase, mind push your local branch before sync and resolve conflicts... |
This pull request is now in conflict... :( |
2e0218c
to
00e73c1
Compare
@Borda I had to redo all the changes again because the batch size scaling was all moved to a new place and now there appears to be a tuner class? I hope this bugfix can be merged before any further modifications and refactoring are made to the tuner. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What does this PR do?
Fixes #3259
and releated to #3266
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃