Fix overfit_batches > 0 on distributed_backend = "ddp" #3534
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @awaelchli! Thanks for updating this PR. There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2020-09-19 12:01:51 UTC |
added 2 commits
September 18, 2020 00:45
SkafteNicki
reviewed
Sep 18, 2020
| @@ -155,7 +155,7 @@ def _get_distributed_sampler(self, dataloader, train): | |||
| assert self.distributed_backend is not None | |||
| kwargs = dict(num_replicas=world_size[self.distributed_backend], rank=self.global_rank) | |||
|
|
|||
| kwargs['shuffle'] = train | |||
| kwargs['shuffle'] = train and not self.overfit_batches | |||
There was a problem hiding this comment.
should we have a test for this?
There was a problem hiding this comment.
@SkafteNicki I tried to find a way but the problem is that this bug affects only ddp, and don't know how to test this due to the multiprocessing.
|
This pull request is now in conflict... :( |
awaelchli
changed the title
awaelchli
force-pushed
the
bugfix/overfit_batches
branch
2 times, most recently
from
2093e52 to
9335769
Compare
Codecov Report
@@ Coverage Diff @@
## master #3534 +/- ##
======================================
Coverage 91% 91%
======================================
Files 109 109
Lines 8080 8080
======================================
Hits 7340 7340
Misses 740 740 |
awaelchli
changed the title
ananthsub
pushed a commit
to ananthsub/pytorch-lightning
that referenced
this pull request
Sep 20, 2020
…3534) * example * ex * example * sampler * fix * fix * remove example * changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #2311
Continuation of #3501
This bug is only present in ddp, it only applies to the case when we replace the distributed sampler
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃