restore functional metrics #3943
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @Borda! Thanks for updating this PR.
Comment last updated at 2020-10-07 16:18:29 UTC |
Borda
requested review from
ananyahjha93,
justusschock,
SkafteNicki and
teddykoker
|
TODO: include functional back in docs |
@justusschock will make in a separate PR :] |
teddykoker
approved these changes
Oct 7, 2020
justusschock
approved these changes
Oct 7, 2020
ananyahjha93
approved these changes
Oct 7, 2020
Codecov Report
@@ Coverage Diff @@
## master #3943 +/- ##
=======================================
+ Coverage 81% 86% +5%
=======================================
Files 113 118 +5
Lines 8581 8903 +322
=======================================
+ Hits 6993 7690 +697
+ Misses 1588 1213 -375 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Restoring functional metrics with their tests, exactly the same sate as it was before merging #3868
Resolves #3868
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃