Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix references for ResultCollection.extra and improve str and repr #8622

Merged
merged 2 commits into from
Jul 30, 2021

Conversation

carmocca
Copy link
Contributor

What does this PR do?

Fixes an issue where the ResultCollection.extra return dict was not set back to the object in the default case.

Also improve its string representations.

Found while debugging #8613

Does your PR introduce any breaking changes? If yes, please list them.

None

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

@carmocca carmocca added the bug Something isn't working label Jul 29, 2021
@carmocca carmocca added this to the v1.4.x milestone Jul 29, 2021
@carmocca carmocca self-assigned this Jul 29, 2021
@codecov
Copy link

codecov bot commented Jul 29, 2021

Codecov Report

Merging #8622 (e82fbcd) into master (c99e2fe) will increase coverage by 0%.
The diff coverage is 90%.

@@          Coverage Diff           @@
##           master   #8622   +/-   ##
======================================
  Coverage      93%     93%           
======================================
  Files         168     168           
  Lines       13951   13956    +5     
======================================
+ Hits        12909   12914    +5     
  Misses       1042    1042           

@carmocca carmocca marked this pull request as ready for review July 29, 2021 15:38
@mergify mergify bot added the ready PRs ready to be merged label Jul 29, 2021
@carmocca carmocca merged commit 9720e26 into master Jul 30, 2021
@carmocca carmocca deleted the bugfix/result-collection-extra-ref branch July 30, 2021 10:47
awaelchli added a commit that referenced this pull request Jul 31, 2021
…pr` (#8622)

Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants