Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add warning when wandb.run already exists #8714

Merged
merged 5 commits into from
Aug 10, 2021
Merged

Conversation

awaelchli
Copy link
Contributor

What does this PR do?

Fixes #8614

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

I made sure I had fun coding 🙃

@awaelchli awaelchli added feature Is an improvement or enhancement logger Related to the Loggers labels Aug 4, 2021
@awaelchli awaelchli added this to the v1.5 milestone Aug 4, 2021
@codecov
Copy link

codecov bot commented Aug 4, 2021

Codecov Report

Merging #8714 (3f5eda6) into master (f1cc6e3) will increase coverage by 0%.
The diff coverage is 100%.

@@          Coverage Diff           @@
##           master   #8714   +/-   ##
======================================
  Coverage      93%     93%           
======================================
  Files         169     169           
  Lines       14068   14071    +3     
======================================
+ Hits        13038   13041    +3     
  Misses       1030    1030           

@borisdayma
Copy link
Contributor

LGTM 🥳

@awaelchli awaelchli marked this pull request as ready for review August 4, 2021 14:28
@mergify mergify bot added the has conflicts label Aug 4, 2021
pytorch_lightning/loggers/wandb.py Show resolved Hide resolved
@mergify mergify bot removed the has conflicts label Aug 9, 2021
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@mergify mergify bot added the ready PRs ready to be merged label Aug 9, 2021
@awaelchli awaelchli merged commit 3ef8cd6 into master Aug 10, 2021
@awaelchli awaelchli deleted the feature/wandb-multi-run branch August 10, 2021 08:14
four4fish pushed a commit to four4fish/pytorch-lightning that referenced this pull request Aug 16, 2021
Co-authored-by: thomas chaton <thomas@grid.ai>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Is an improvement or enhancement logger Related to the Loggers ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5-Fold with PyTorchLightning + Wandb seems to log to the same experiment
5 participants