Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bugfix] Resolve lost reference to meta object in ResultMetricCollection #8932

Merged
merged 3 commits into from
Aug 16, 2021

Conversation

tchaton
Copy link
Contributor

@tchaton tchaton commented Aug 16, 2021

What does this PR do?

This PR resolves a bug where the meta object was lost during ResultCollection.to function.

I removed entirely the usage of Metadata through the init function as this was definitely a wrong pattern.

Now, the meta object is resolved directly from the children.

Fixes #8918

Does your PR introduce any breaking changes? If yes, please list them.

No.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@tchaton tchaton added bug Something isn't working logging Related to the `LoggerConnector` and `log()` labels Aug 16, 2021
@tchaton tchaton added this to the v1.4.x milestone Aug 16, 2021
@tchaton tchaton self-assigned this Aug 16, 2021
@codecov
Copy link

codecov bot commented Aug 16, 2021

Codecov Report

Merging #8932 (6da0be1) into master (93ab24d) will increase coverage by 0%.
The diff coverage is 100%.

@@          Coverage Diff           @@
##           master   #8932   +/-   ##
======================================
  Coverage      93%     93%           
======================================
  Files         172     172           
  Lines       14096   14096           
======================================
+ Hits        13098   13099    +1     
+ Misses        998     997    -1     

@mergify mergify bot removed the has conflicts label Aug 16, 2021
@mergify mergify bot added the ready PRs ready to be merged label Aug 16, 2021
@tchaton tchaton enabled auto-merge (squash) August 16, 2021 17:21
@tchaton tchaton merged commit f0a105b into master Aug 16, 2021
@tchaton tchaton deleted the bugfix/8918_logging branch August 16, 2021 17:21
kaushikb11 pushed a commit to kaushikb11/pytorch-lightning that referenced this pull request Aug 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working logging Related to the `LoggerConnector` and `log()` ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

self.log validation_step Misconfiguration error
4 participants