Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deprecate the TestTubeLogger #9065

Merged
merged 7 commits into from
Aug 26, 2021
Merged

deprecate the TestTubeLogger #9065

merged 7 commits into from
Aug 26, 2021

Conversation

awaelchli
Copy link
Contributor

@awaelchli awaelchli commented Aug 23, 2021

What does this PR do?

The test-tube package is not maintained anymore. The discussion was to drop the logger from Lightning.

Fixes #9037
Closes #7542

Does your PR introduce any breaking changes? If yes, please list them.

From 1.7, the TestTubeLogger wrapper will be removed.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

I made sure I had fun coding 🙃

@awaelchli awaelchli added logger Related to the Loggers 3rd party Related to a 3rd-party deprecation Includes a deprecation labels Aug 23, 2021
@codecov
Copy link

codecov bot commented Aug 23, 2021

Codecov Report

Merging #9065 (f4c468e) into master (9d62f24) will decrease coverage by 4%.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master   #9065    +/-   ##
=======================================
- Coverage      92%     88%    -4%     
=======================================
  Files         175     175            
  Lines       14665   14699    +34     
=======================================
- Hits        13499   12899   -600     
- Misses       1166    1800   +634     

Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT !

CHANGELOG.md Outdated Show resolved Hide resolved
awaelchli and others added 3 commits August 26, 2021 01:34
Co-authored-by: Kaushik B <45285388+kaushikb11@users.noreply.github.com>
Co-authored-by: Kaushik B <45285388+kaushikb11@users.noreply.github.com>
@awaelchli awaelchli marked this pull request as ready for review August 25, 2021 23:38
Copy link
Contributor

@ananthsub ananthsub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@mergify mergify bot added the ready PRs ready to be merged label Aug 25, 2021
@Borda Borda requested a review from kaushikb11 August 26, 2021 06:00
@awaelchli awaelchli added this to the v1.5 milestone Aug 26, 2021
@awaelchli awaelchli enabled auto-merge (squash) August 26, 2021 08:11
@awaelchli awaelchli merged commit 8efdeb2 into master Aug 26, 2021
@awaelchli awaelchli deleted the feature/deprecate-test-tube branch August 26, 2021 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3rd party Related to a 3rd-party deprecation Includes a deprecation logger Related to the Loggers ready PRs ready to be merged
Projects
None yet
6 participants