-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deprecate the TestTubeLogger #9065
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
awaelchli
added
logger
Related to the Loggers
3rd party
Related to a 3rd-party
deprecation
Includes a deprecation
labels
Aug 23, 2021
for more information, see https://pre-commit.ci
Codecov Report
@@ Coverage Diff @@
## master #9065 +/- ##
=======================================
- Coverage 92% 88% -4%
=======================================
Files 175 175
Lines 14665 14699 +34
=======================================
- Hits 13499 12899 -600
- Misses 1166 1800 +634 |
tchaton
approved these changes
Aug 25, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGMT !
kaushikb11
reviewed
Aug 25, 2021
kaushikb11
reviewed
Aug 25, 2021
Co-authored-by: Kaushik B <45285388+kaushikb11@users.noreply.github.com>
Co-authored-by: Kaushik B <45285388+kaushikb11@users.noreply.github.com>
awaelchli
requested review from
Borda,
carmocca,
justusschock,
SeanNaren and
williamFalcon
as code owners
August 25, 2021 23:38
ananthsub
approved these changes
Aug 25, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
carmocca
approved these changes
Aug 26, 2021
Borda
approved these changes
Aug 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
3rd party
Related to a 3rd-party
deprecation
Includes a deprecation
logger
Related to the Loggers
ready
PRs ready to be merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The test-tube package is not maintained anymore. The discussion was to drop the logger from Lightning.
Fixes #9037
Closes #7542
Does your PR introduce any breaking changes? If yes, please list them.
From 1.7, the TestTubeLogger wrapper will be removed.
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
I made sure I had fun coding 🙃