-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
scheduled removal of BaseProfiler.output_filename in favor of dirpath… #9214
Merged
awaelchli
merged 6 commits into
Lightning-AI:master
from
Tshimanga:removal/1.5-profiler-output-filename
Aug 31, 2021
Merged
scheduled removal of BaseProfiler.output_filename in favor of dirpath… #9214
awaelchli
merged 6 commits into
Lightning-AI:master
from
Tshimanga:removal/1.5-profiler-output-filename
Aug 31, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tshimanga
requested review from
awaelchli,
Borda,
carmocca,
justusschock,
kaushikb11,
SeanNaren,
tchaton and
williamFalcon
as code owners
August 31, 2021 01:04
carmocca
approved these changes
Aug 31, 2021
carmocca
added
breaking change
Includes a breaking change
deprecation
Includes a deprecation
profiler
labels
Aug 31, 2021
ananthsub
approved these changes
Aug 31, 2021
awaelchli
approved these changes
Aug 31, 2021
Borda
approved these changes
Aug 31, 2021
tchaton
approved these changes
Aug 31, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks !
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
breaking change
Includes a breaking change
deprecation
Includes a deprecation
profiler
ready
PRs ready to be merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… and filename
Removes BaseProfiler.output_filename from that class and its descendants in favor of dirpath and filename as scheduled for 1.5
Does your PR introduce any breaking changes? If yes, please list them.
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃