Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scheduled removal of BaseProfiler.output_filename in favor of dirpath… #9214

Merged

Conversation

Tshimanga
Copy link
Contributor

@Tshimanga Tshimanga commented Aug 31, 2021

… and filename

Removes BaseProfiler.output_filename from that class and its descendants in favor of dirpath and filename as scheduled for 1.5

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@carmocca carmocca added this to the v1.5 milestone Aug 31, 2021
@carmocca carmocca added breaking change Includes a breaking change deprecation Includes a deprecation profiler labels Aug 31, 2021
@mergify mergify bot added the ready PRs ready to be merged label Aug 31, 2021
CHANGELOG.md Outdated Show resolved Hide resolved
@awaelchli awaelchli enabled auto-merge (squash) August 31, 2021 08:01
@mergify mergify bot removed the has conflicts label Aug 31, 2021
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks !

@awaelchli awaelchli merged commit f6614b3 into Lightning-AI:master Aug 31, 2021
@Tshimanga Tshimanga deleted the removal/1.5-profiler-output-filename branch August 31, 2021 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change Includes a breaking change deprecation Includes a deprecation profiler ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants