Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent loss to be moved to the cpu before backward call. #9308

Merged
merged 7 commits into from
Sep 3, 2021

Conversation

tchaton
Copy link
Contributor

@tchaton tchaton commented Sep 3, 2021

What does this PR do?

Fixes #9296

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@tchaton tchaton added the bug Something isn't working label Sep 3, 2021
@tchaton tchaton added this to the v1.4.x milestone Sep 3, 2021
@tchaton tchaton self-assigned this Sep 3, 2021
tests/trainer/logging_/test_eval_loop_logging.py Outdated Show resolved Hide resolved
tests/trainer/logging_/test_eval_loop_logging.py Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Sep 3, 2021

Codecov Report

Merging #9308 (490c45b) into master (b91747e) will decrease coverage by 4%.
The diff coverage is 100%.

❗ Current head 490c45b differs from pull request most recent head 0689444. Consider uploading reports for the commit 0689444 to get more accurate results

@@           Coverage Diff           @@
##           master   #9308    +/-   ##
=======================================
- Coverage      92%     88%    -4%     
=======================================
  Files         178     178            
  Lines       14855   14855            
=======================================
- Hits        13704   13093   -611     
- Misses       1151    1762   +611     

@tchaton tchaton enabled auto-merge (squash) September 3, 2021 12:54
@mergify mergify bot added the ready PRs ready to be merged label Sep 3, 2021
@tchaton tchaton merged commit f6d4087 into master Sep 3, 2021
@tchaton tchaton deleted the bugfix/9296_move_metrics_to_cpu branch September 3, 2021 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Loss not on correct device when training with move_metrics_to_cpu=True
4 participants