Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating the spec for clarity and parity with the implementation of the V7 transaction details #55

Merged
merged 5 commits into from
Jul 19, 2024

Conversation

vivek-arte
Copy link

@vivek-arte vivek-arte commented Jul 9, 2024

A quick summary of the changes here:

  • The assetDescSize field in the issuance action description is encoded as a compactSize type, as is standard across the specification (and also allows for the use of the existing methods in the implementation).
  • The description of the notes used inside the issuance bundle were explicitly serialized to remove ambiguity.
  • The type of the valueBurn field was set to the standard uint64 type.
  • The order of the Orchard bundle fields was adjusted to have the binding signature after the burn fields.

Copy link

netlify bot commented Jul 9, 2024

Deploy Preview for zcash-zips-qedit ready!

Name Link
🔨 Latest commit 6683c1c
🔍 Latest deploy log https://app.netlify.com/sites/zcash-zips-qedit/deploys/669a9d00dc7c36000848c9f4
😎 Deploy Preview https://deploy-preview-55--zcash-zips-qedit.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

@PaulLaux PaulLaux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice, added small comments

zip-0230.rst Outdated Show resolved Hide resolved
zip-0230.rst Outdated Show resolved Hide resolved
@vivek-arte vivek-arte merged commit d8fba69 into zsa1 Jul 19, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants