Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Elaborate on types of transpiler passes #1086

Merged
merged 5 commits into from
Apr 15, 2024
Merged

Elaborate on types of transpiler passes #1086

merged 5 commits into from
Apr 15, 2024

Conversation

kaelynj
Copy link
Collaborator

@kaelynj kaelynj commented Mar 25, 2024

Closes #1075

Essentially just added a few sentences explaining more about the TransformationPass and AnalysisPass and added links to their respective API docs.

@kaelynj kaelynj requested a review from abbycross March 25, 2024 20:33
@qiskit-bot
Copy link
Contributor

Thanks for contributing to Qiskit documentation!

Before your PR can be merged, it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient. Thanks! 🙌

One or more of the the following people are requested to review this:

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

when you say "these are passes which will translate circuits to its ISA...." are you referring to both analysis and transformation passes? or just the transformation pass? the rest is great, just the last sentence im confused about which we're talking about

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just the transformation pass. I just changed that sentence up a bit to make it clearer.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that looks great, it is clearer and more detailed.

The only thing I could think of was maybe altering the last sentence a tiny bit.
You could add something like :
"For example, transformation passes will translate a circuit to its ISA which defines the set of instructions supported by a specific quantum device."

This would be for someone who just wants the gist and not to read a new page

Copy link
Collaborator

@javabster javabster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

Copy link
Collaborator

@abbycross abbycross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Co-authored-by: abbycross <across@us.ibm.com>
@kaelynj kaelynj added this pull request to the merge queue Apr 15, 2024
Merged via the queue into main with commit 3c9d4be Apr 15, 2024
5 checks passed
@kaelynj kaelynj deleted the kjf/transpiler-types branch April 15, 2024 22:25
frankharkins pushed a commit to frankharkins/documentation that referenced this pull request Jul 22, 2024
Closes Qiskit#1075 

Essentially just added a few sentences explaining more about the
`TransformationPass` and `AnalysisPass` and added links to their
respective API docs.

---------

Co-authored-by: abbycross <across@us.ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Expand on definitions of the types of transpiler passes
5 participants