-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Elaborate on types of transpiler passes #1086
Conversation
Thanks for contributing to Qiskit documentation! Before your PR can be merged, it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient. Thanks! 🙌 One or more of the the following people are requested to review this:
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
when you say "these are passes which will translate circuits to its ISA...." are you referring to both analysis and transformation passes? or just the transformation pass? the rest is great, just the last sentence im confused about which we're talking about
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just the transformation pass. I just changed that sentence up a bit to make it clearer.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that looks great, it is clearer and more detailed.
The only thing I could think of was maybe altering the last sentence a tiny bit.
You could add something like :
"For example, transformation passes will translate a circuit to its ISA which defines the set of instructions supported by a specific quantum device."
This would be for someone who just wants the gist and not to read a new page
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Co-authored-by: abbycross <across@us.ibm.com>
Closes Qiskit#1075 Essentially just added a few sentences explaining more about the `TransformationPass` and `AnalysisPass` and added links to their respective API docs. --------- Co-authored-by: abbycross <across@us.ibm.com>
Closes #1075
Essentially just added a few sentences explaining more about the
TransformationPass
andAnalysisPass
and added links to their respective API docs.