Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add output for code examples #1146

Merged
merged 8 commits into from
May 9, 2024
Merged

Add output for code examples #1146

merged 8 commits into from
May 9, 2024

Conversation

beckykd
Copy link
Collaborator

@beckykd beckykd commented Apr 5, 2024

closes #1143

@beckykd beckykd marked this pull request as ready for review April 8, 2024 16:24
@qiskit-bot
Copy link
Contributor

Thanks for contributing to Qiskit documentation!

Before your PR can be merged, it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient. Thanks! 🙌

One or more of the the following people are requested to review this:

@beckykd beckykd requested review from ElePT and Eric-Arellano April 8, 2024 16:24
docs/run/primitives-examples.mdx Outdated Show resolved Hide resolved
docs/run/primitives-examples.mdx Outdated Show resolved Hide resolved
Copy link
Collaborator

@abbycross abbycross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Words look good :-)

@beckykd beckykd added this pull request to the merge queue May 9, 2024
Merged via the queue into main with commit c808f36 May 9, 2024
4 checks passed
@beckykd beckykd deleted the add-output branch May 9, 2024 20:58
Copy link
Collaborator

@Eric-Arellano Eric-Arellano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this!

docs/run/primitives-examples.mdx Show resolved Hide resolved
docs/run/primitives-examples.mdx Show resolved Hide resolved
docs/run/primitives-examples.mdx Show resolved Hide resolved
docs/run/primitives-examples.mdx Show resolved Hide resolved
docs/run/primitives-examples.mdx Show resolved Hide resolved
docs/run/primitives-examples.mdx Show resolved Hide resolved
docs/run/primitives-examples.mdx Show resolved Hide resolved
github-merge-queue bot pushed a commit that referenced this pull request May 10, 2024
Follow up to #1146. There
were a few issues:

* all imports should be at the top of the code block
* we were defining Estimator a few times it was not used, or that it was
redeclared later
* not using the n_qubits arg

---------

Co-authored-by: Rebecca Dimock <66339736+beckykd@users.noreply.github.com>
frankharkins pushed a commit to frankharkins/documentation that referenced this pull request Jul 22, 2024
frankharkins pushed a commit to frankharkins/documentation that referenced this pull request Jul 22, 2024
Follow up to Qiskit#1146. There
were a few issues:

* all imports should be at the top of the code block
* we were defining Estimator a few times it was not used, or that it was
redeclared later
* not using the n_qubits arg

---------

Co-authored-by: Rebecca Dimock <66339736+beckykd@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Show more sample output with primitives
5 participants