Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tutorial housekeeping: Build repetition codes #1157

Merged
merged 12 commits into from
May 28, 2024

Conversation

beckykd
Copy link
Collaborator

@beckykd beckykd commented Apr 10, 2024

Closes #1137

FYI @RoyElkabetz

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@RoyElkabetz
Copy link
Contributor

Hi @beckykd, could you please run the notebook and commit with fresh output so I could review the changes?

@beckykd beckykd marked this pull request as ready for review May 21, 2024 13:14
@qiskit-bot
Copy link
Contributor

Thanks for contributing to Qiskit documentation!

Before your PR can be merged, it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient. Thanks! 🙌

@javabster
Copy link
Collaborator

Looks great! my comments:

  • For the esitmated QPU usage can we use the same wording we used here (and make it italics): https://learning.quantum.ibm.com/tutorial/combine-error-mitigation-options-with-the-estimator-primitive
  • For the background section are there any papers we could link to for people who want to explore QEC in more depth?
  • for the requirements section we've been combining the qiskit sdk line with the visualisation support line (see tutorial linked above)
  • in the optimize section could we add a link to the transpiler docs with more info on ISA circuits
  • we probably don't need to print out the versions at the end, I dont think we do that in other tutorials and the required version is stated at the top
  • Do you think it's possible to add a scale-up section to the end of this notebook, to show how this could be applied in a utility scale experiment?

@beckykd
Copy link
Collaborator Author

beckykd commented May 21, 2024

  • add a scale-up section

I added all the updates except this. Working on figuring out an appropriate example.

@ihincks
Copy link
Contributor

ihincks commented May 24, 2024

Do you think it's possible to add a scale-up section to the end of this notebook, to show how this could be applied in a utility scale experiment

My take on this is that it's not crucial to demonstrate utlity scale for QEC examples because that hasn't be the focus of IBM utility-scale experiments to date: they have all been about things like trotterized Hamiltonian simulations with mitigation.

If this direction is mandatory, the repetition code could be kept, but repeated to more than three qubits. The routing would get quite a bit more complicated. But also, there would be a tonne of conditional if statements which are quite slow especially when done serially, and degrade the quality of the experiment. However, pushing this strategy too far would make the example feel contrived, and the results would not be great, I expect.

@beckykd beckykd added this pull request to the merge queue May 28, 2024
Merged via the queue into main with commit 9636bf3 May 28, 2024
3 checks passed
@beckykd beckykd deleted the update-build-repetition-codes branch May 28, 2024 19:54
@beckykd beckykd restored the update-build-repetition-codes branch June 10, 2024 16:18
@beckykd beckykd mentioned this pull request Jun 10, 2024
@beckykd beckykd changed the title Update Build repetition codes tutorial Tutorial housekeeping: Build repetition codes Jun 10, 2024
frankharkins pushed a commit to frankharkins/documentation that referenced this pull request Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Review/refactor "build repetition codes" tutorial
6 participants