-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Repeat until success notebook #1192
Conversation
Thanks for contributing to Qiskit documentation! Before your PR can be merged, it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient. Thanks! 🙌 |
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The notebook is failing on code cell 2 with provider = IBMProvider()
.
It seems like the current notebook version is different from the one we had on ibm-quantum-learning-enablement.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
(Sorry I can't comment in context; the raw git diff is too large to be displayed and we can't comment on the rich diff, alas!) In Block [4], line 12 ( Also in Block [4], line 1 -- where the heralding is described... does that happen automatically (thereby justifying the passive voice) or does the user choose what to apply after they see the measurements? ('both control bit measurements return |
Grrr.
Done
It happens automatically. Thanks! |
…epeat-until-success-updates
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
closes Qiskit#1138 copy over edits from learning repo made by @RoyElkabetz and myself: ***REMOVED*** --------- Co-authored-by: ABBY CROSS <across@us.ibm.com>
closes #1138
copy over edits from learning repo made by @RoyElkabetz and myself