Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Repeat until success notebook #1192

Merged
merged 11 commits into from
Apr 22, 2024
Merged

Conversation

beckykd
Copy link
Collaborator

@beckykd beckykd commented Apr 17, 2024

closes #1138

copy over edits from learning repo made by @RoyElkabetz and myself

@qiskit-bot
Copy link
Contributor

Thanks for contributing to Qiskit documentation!

Before your PR can be merged, it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient. Thanks! 🙌

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@beckykd beckykd requested a review from RoyElkabetz April 17, 2024 20:24
Copy link
Contributor

@RoyElkabetz RoyElkabetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The notebook is failing on code cell 2 with provider = IBMProvider().
It seems like the current notebook version is different from the one we had on ibm-quantum-learning-enablement.

Copy link
Contributor

@RoyElkabetz RoyElkabetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@RoyElkabetz RoyElkabetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@abbycross
Copy link
Collaborator

(Sorry I can't comment in context; the raw git diff is too large to be displayed and we can't comment on the rich diff, alas!)

In Block [4], line 12 (If there is a failure, you should reset the "dirty" state and start again.) I would just remove "you should".

Also in Block [4], line 1 -- where the heralding is described... does that happen automatically (thereby justifying the passive voice) or does the user choose what to apply after they see the measurements? ('both control bit measurements return $0$, the gate $R_X(\theta)$ with $\cos\theta = \frac35$ is applied. If any of the measurements are $1$, gate $X$ is applied, which is a failure.`)

@beckykd
Copy link
Collaborator Author

beckykd commented Apr 19, 2024

(Sorry I can't comment in context; the raw git diff is too large to be displayed and we can't comment on the rich diff, alas!)

Grrr.

In Block [4], line 12 (If there is a failure, you should reset the "dirty" state and start again.) I would just remove "you should".

Done

Also in Block [4], line 1 -- where the heralding is described... does that happen automatically (thereby justifying the passive voice) or does the user choose what to apply after they see the measurements? ('both control bit measurements return 0, the gate RX(θ) with cos⁡θ=35 is applied. If any of the measurements are 1, gate X is applied, which is a failure.`)

It happens automatically. Thanks!

Copy link
Contributor

@RoyElkabetz RoyElkabetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@beckykd beckykd added this pull request to the merge queue Apr 22, 2024
Merged via the queue into main with commit a0098cc Apr 22, 2024
3 checks passed
@beckykd beckykd deleted the repeat-until-success-updates branch April 22, 2024 18:23
frankharkins pushed a commit to frankharkins/documentation that referenced this pull request Jul 22, 2024
closes Qiskit#1138

copy over edits from learning repo made by @RoyElkabetz and myself:
***REMOVED***

---------

Co-authored-by: ABBY CROSS <across@us.ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Review/refactor "Repeat until success" tutorial
4 participants