-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tutorial for error mitigation with Qiskit Runtime Estimator #1313
Conversation
Co-authored-by: Abdullah Ash- Saki <44783187+ashsaki@users.noreply.github.com> Co-authored-by: Pedro Rivero <pedro.rivero.ramirez@gmail.com> Co-authored-by: Ritajit Majumdar <majumdar.ritajit@gmail.com> Co-authored-by: haimeng-zhang <33587226+haimeng-zhang@users.noreply.github.com>
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Phenomenal work Kevin! my comments:
Overall I think this is a great simplified version of the notebook, but i think we should definitely follow up with more of a deep dive into the different error mitigation techniques in additional documentation |
@kevinsung does this recent comment about breaking changes to the Estimator result data for ZNE affect your tutorial? |
- list of requirements - mention approach is generalizable to different circuits - mention notebook plan of going from 10 to 50 qubits - list error mitigation techniques in intro - expand prose in "scaling up" section and add conclusion
I don't think so. I only access the ZNE results using the |
@javabster I've addressed your comments. I also added a "Conclusion" section and made a few other minor edits. Please take another look. |
The main reason is simply ease of visualization. If you try to draw a 50-qubit circuit it's very slow and the output is too large to view comfortably. Also, in general it's preferable to build and test a workflow on small circuits first (I mention this now in the notebook). |
Looking great! Some last final small things:
|
I don't think we should list Numpy and Matplotlib as explicit requirements because that would be redundant and noisy. Numpy is already a dependency of Qiskit (and just about every other Python library that works with numbers). And we already explicitly say Qiskit needs to be installed "with visualization support" which implies Matplotlib. Thoughts? |
I see your point about mpl but when you install qiskit does it also install numpy for you? I thought you had to install that separately |
Yes, installing Qiskit installs Numpy too. |
Done |
Looks very nice! |
Done! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
77f98a8
to
967587c
Compare
…it#1313) Fixes Qiskit#1168 --------- Co-authored-by: Abdullah Ash- Saki <44783187+ashsaki@users.noreply.github.com> Co-authored-by: Pedro Rivero <pedro.rivero.ramirez@gmail.com> Co-authored-by: Ritajit Majumdar <majumdar.ritajit@gmail.com> Co-authored-by: haimeng-zhang <33587226+haimeng-zhang@users.noreply.github.com>
Fixes #1168