Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't truncate API ToC by default #1318

Merged
merged 2 commits into from
May 8, 2024
Merged

Don't truncate API ToC by default #1318

merged 2 commits into from
May 8, 2024

Conversation

Eric-Arellano
Copy link
Collaborator

Turns out, this truncation does not work well with #1317. We agreed the best approach is to show the full module path for that package.

This PR also fixes #1308 to put the error in the correct location.

Copy link
Collaborator

@arnaucasau arnaucasau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thanks!

scripts/lib/api/Pkg.ts Show resolved Hide resolved
@Eric-Arellano Eric-Arellano added this pull request to the merge queue May 8, 2024
Merged via the queue into main with commit e2e765a May 8, 2024
2 checks passed
@Eric-Arellano Eric-Arellano deleted the EA/no-truncation branch May 8, 2024 11:15
frankharkins pushed a commit to frankharkins/documentation that referenced this pull request Jul 22, 2024
Turns out, this truncation does not work well with
Qiskit#1317. We agreed the best
approach is to show the full module path for that package.

This PR also fixes Qiskit#1308 to
put the error in the correct location.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants