Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make generic scripts for new projects #1320

Merged
merged 2 commits into from
May 8, 2024
Merged

Conversation

Eric-Arellano
Copy link
Collaborator

Unblocks #1317

Context: we can't use api/* for globs because it would match against api/migration-guides.

Copy link
Collaborator

@arnaucasau arnaucasau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! Much better using the Pkg.VALID_NAMES for future extensions in the APIs

scripts/commands/checkMetadata.ts Outdated Show resolved Hide resolved
Co-authored-by: Arnau Casau <47946624+arnaucasau@users.noreply.github.com>
@Eric-Arellano Eric-Arellano added this pull request to the merge queue May 8, 2024
Merged via the queue into main with commit 87e7cac May 8, 2024
2 checks passed
@Eric-Arellano Eric-Arellano deleted the EA/generify-scripts branch May 8, 2024 11:14
frankharkins pushed a commit to frankharkins/documentation that referenced this pull request Jul 22, 2024
Unblocks Qiskit#1317

Context: we can't use `api/*` for globs because it would match against
`api/migration-guides`.

---------

Co-authored-by: Arnau Casau <47946624+arnaucasau@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants