Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix code examples in primitives-examples.mdx #1342

Merged
merged 3 commits into from
May 10, 2024
Merged

Conversation

Eric-Arellano
Copy link
Collaborator

Follow up to #1146. There were a few issues:

  • all imports should be at the top of the code block
  • we were defining Estimator a few times it was not used, or that it was redeclared later
  • not using the n_qubits arg

@qiskit-bot
Copy link
Contributor

One or more of the the following people are requested to review this:

Copy link
Collaborator

@abbycross abbycross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 but should also have a more code-literate person approve 😄

@Eric-Arellano Eric-Arellano requested a review from kevinsung May 10, 2024 15:05
@beckykd beckykd added this pull request to the merge queue May 10, 2024
Merged via the queue into main with commit 60e36ca May 10, 2024
4 checks passed
@beckykd beckykd deleted the EA/primites-output branch May 10, 2024 20:36
frankharkins pushed a commit to frankharkins/documentation that referenced this pull request Jul 22, 2024
Follow up to Qiskit#1146. There
were a few issues:

* all imports should be at the top of the code block
* we were defining Estimator a few times it was not used, or that it was
redeclared later
* not using the n_qubits arg

---------

Co-authored-by: Rebecca Dimock <66339736+beckykd@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

5 participants