Use the new labels mechanism in docs guide reorganization #1464
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arnaucasau
reviewed
May 31, 2024
|
|
||
|
|
||
| def postprocess_index_content(index: str) -> str: | ||
| return ( | ||
| "# Post-process results\n\n" |
There was a problem hiding this comment.
I see that all the other sections preserve the title except this one. Is this intentional?
There was a problem hiding this comment.
Oh, oops. Good catch!
Eric-Arellano
commented
May 31, 2024
arnaucasau
approved these changes
May 31, 2024
frankharkins
pushed a commit
to frankharkins/documentation
that referenced
this pull request
Jul 22, 2024
This also improves the patterns index pages: * adds missing metadata * uses `dedent()` so the code is easier to modify * Adds an h2 `Guides` --------- Co-authored-by: Arnau Casau <47946624+arnaucasau@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also improves the patterns index pages:
dedent()so the code is easier to modifyGuides