-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add error mitigation explanation notebook #1482
Conversation
Co-authored-by: Abdullah Ash- Saki <44783187+ashsaki@users.noreply.github.com> Co-authored-by: Pedro Rivero <pedro.rivero.ramirez@gmail.com>
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Hmm the embedded images seem to be giving the CI issue. Gonna need to investigate... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking really good! I think this is going to be a very helpful docs page.
I left some in line comments and I have these general ones:
- please add a "next steps" section like we do for the other docs pages. I think we can add a link to the tutorial on combining EM techniques, as well as maybe the API reference
- Do you think we should add a section about PEA? I know it's technically only available through the experimental branch for now but we have docs for other experimental features so I can see a case for including here too
@javabster I've addressed your comments.
I think we should document PEA once it's generally available, since the way that the options are exposed would probably affect the exposition. We shouldn't document options that aren't available yet. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I caught a few small word things - otherwise it reads very well, as always!
Co-authored-by: Jessie Yu <jessieyu@us.ibm.com>
Co-authored-by: abbycross <across@us.ibm.com>
Co-authored-by: Jessie Yu <jessieyu@us.ibm.com>
Co-authored-by: Jessie Yu <jessieyu@us.ibm.com> Co-authored-by: abbycross <across@us.ibm.com>
Co-authored-by: abbycross <across@us.ibm.com>
Fixes Qiskit#1355 . No material on PEA yet because it's not exposed as an [option](https://docs.quantum.ibm.com/api/qiskit-ibm-runtime/options). --------- Co-authored-by: Abdullah Ash- Saki <44783187+ashsaki@users.noreply.github.com> Co-authored-by: Pedro Rivero <pedro.rivero.ramirez@gmail.com> Co-authored-by: Jessie Yu <jessieyu@us.ibm.com> Co-authored-by: abbycross <across@us.ibm.com> Co-authored-by: Arnau Casau <arnaucasau@gmail.com>
Fixes #1355 .
No material on PEA yet because it's not exposed as an option.