Skip to content

Conversation

@kaelynj
Copy link
Collaborator

@kaelynj kaelynj commented Jun 10, 2024

Closes #1440

@kevinsung, here's what I have so far in terms of content to include. I think it might be worth mentioning the overloaded operators for the SparsePauliOp class and demonstrate some of the algebra that can be done.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@kevinsung
Copy link
Collaborator

thanks @kaelynj I'll take it from here

@kevinsung
Copy link
Collaborator

I've made the following changes:

  • Reordered sections to put SparsePauliOp first
  • Added arithmetic examples for SparsePauliOp
  • Updated prose
  • Split out in-depth explanation of Operator class to a separate page
  • Changed link to Grover tutorial, which doesn't actually use operator, to estimator error mitigation tutorial

@javabster PTAL

@kevinsung kevinsung marked this pull request as ready for review June 10, 2024 18:09
@qiskit-bot
Copy link
Contributor

Thanks for contributing to Qiskit documentation!

Before your PR can be merged, it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient. Thanks! 🙌

@kevinsung kevinsung requested a review from javabster June 10, 2024 18:10
@kevinsung kevinsung changed the title Outline Pauli and SparsePauliOp content Update "operators overview" page to highlight SparsePauliOp and split in-depth Operator coverage to separate page Jun 10, 2024
"source": [
"# The Operator class\n",
"\n",
"This page shows how to use the [`Operator`](/api/qiskit/qiskit.quantum_info.Operator) class. For a high-level overview of the class, see [Overview of operator classes](/build/operators-overview#operator)."
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"This page shows how to use the [`Operator`](/api/qiskit/qiskit.quantum_info.Operator) class. For a high-level overview of the class, see [Overview of operator classes](/build/operators-overview#operator)."
"This page shows how to use the [`Operator`](/api/qiskit/qiskit.quantum_info.Operator) class. For a high-level overview of the `quantum_info` module, including the `Operator` class and others, see [Operators module overview](/build/operators-overview)."

I think this is a bit clearer, currently it's a bit vague to me about what is the difference between the 2 pages just from the intro description

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That page doesn't actually give an overview of the quantum_info module, only the operator classes. I've changed the sentence to

For a high-level overview of operator representations in Qiskit, including the Operator class and others, see Overview of operator classes.

@kevinsung
Copy link
Collaborator

@javabster please take another look

Copy link
Contributor

@javabster javabster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@kevinsung kevinsung added this pull request to the merge queue Jun 17, 2024
Merged via the queue into main with commit 65a0847 Jun 17, 2024
@kevinsung kevinsung deleted the kjf/explain-sparsepauliop branch June 17, 2024 18:44
github-merge-queue bot pushed a commit that referenced this pull request Jun 19, 2024
Noticed a few edits to make in a [recent closed
PR](#1517).

- Changed "we" to "you"
- avoided "will" when appropriate
- replaced "may" with either "can" or "might" depending on context
- general typo/punctuation/capitalization cleanup
frankharkins pushed a commit to frankharkins/documentation that referenced this pull request Jul 22, 2024
… in-depth Operator coverage to separate page (Qiskit#1517)

Closes Qiskit#1440 

@kevinsung, here's what I have so far in terms of content to include. I
think it might be worth mentioning the overloaded operators for the
`SparsePauliOp` class and demonstrate some of the algebra that can be
done.

---------

Co-authored-by: Kevin J. Sung <kevjsung@umich.edu>
frankharkins pushed a commit to frankharkins/documentation that referenced this pull request Jul 22, 2024
Noticed a few edits to make in a [recent closed
PR](Qiskit#1517).

- Changed "we" to "you"
- avoided "will" when appropriate
- replaced "may" with either "can" or "might" depending on context
- general typo/punctuation/capitalization cleanup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

Add explanation of SparsePauliOp

4 participants