-
Notifications
You must be signed in to change notification settings - Fork 152
Update "operators overview" page to highlight SparsePauliOp and split in-depth Operator coverage to separate page #1517
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
|
thanks @kaelynj I'll take it from here |
|
I've made the following changes:
@javabster PTAL |
|
Thanks for contributing to Qiskit documentation! Before your PR can be merged, it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient. Thanks! 🙌 |
docs/build/operator-class.ipynb
Outdated
| "source": [ | ||
| "# The Operator class\n", | ||
| "\n", | ||
| "This page shows how to use the [`Operator`](/api/qiskit/qiskit.quantum_info.Operator) class. For a high-level overview of the class, see [Overview of operator classes](/build/operators-overview#operator)." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| "This page shows how to use the [`Operator`](/api/qiskit/qiskit.quantum_info.Operator) class. For a high-level overview of the class, see [Overview of operator classes](/build/operators-overview#operator)." | |
| "This page shows how to use the [`Operator`](/api/qiskit/qiskit.quantum_info.Operator) class. For a high-level overview of the `quantum_info` module, including the `Operator` class and others, see [Operators module overview](/build/operators-overview)." |
I think this is a bit clearer, currently it's a bit vague to me about what is the difference between the 2 pages just from the intro description
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That page doesn't actually give an overview of the quantum_info module, only the operator classes. I've changed the sentence to
For a high-level overview of operator representations in Qiskit, including the
Operatorclass and others, see Overview of operator classes.
|
@javabster please take another look |
javabster
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
Noticed a few edits to make in a [recent closed PR](#1517). - Changed "we" to "you" - avoided "will" when appropriate - replaced "may" with either "can" or "might" depending on context - general typo/punctuation/capitalization cleanup
… in-depth Operator coverage to separate page (Qiskit#1517) Closes Qiskit#1440 @kevinsung, here's what I have so far in terms of content to include. I think it might be worth mentioning the overloaded operators for the `SparsePauliOp` class and demonstrate some of the algebra that can be done. --------- Co-authored-by: Kevin J. Sung <kevjsung@umich.edu>
Noticed a few edits to make in a [recent closed PR](Qiskit#1517). - Changed "we" to "you" - avoided "will" when appropriate - replaced "may" with either "can" or "might" depending on context - general typo/punctuation/capitalization cleanup
Closes #1440
@kevinsung, here's what I have so far in terms of content to include. I think it might be worth mentioning the overloaded operators for the
SparsePauliOpclass and demonstrate some of the algebra that can be done.