-
Notifications
You must be signed in to change notification settings - Fork 155
Split visualization page into three #977
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
…H/split-visualization
* Copy / code edits * Format with black * Lint notebook * Re-run notebook with Qiskit 1.0
* Use tabs to condense information * Delegate some information to API docs * Avoid repeating information
abbycross
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice job and I love the use of the tabs for the different visualization types! Super cool. I had some lightweight suggestions and also pushed some changes from my local branch - hope that's ok; feel free to revert anything you don't like!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It'd be helpful to talk about how to visualize results for the Estimator primitive. In Hello World, we use plt.errorbar, but I think @kaelynj and Kevin were saying another type of graph would be more useful.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good call, I've had a go at that in Plotting estimator results. I'm gonna get some more reviewers though as my stats knowledge is quite shaky.
Co-authored-by: abbycross <across@us.ibm.com>
I think the "correct" term is state vector, but statevector is a common compouding that happens quite a lot within Qiskit (e.g. we called the class IIRC we discussed this at some point with Jennifer and Becky and decided to double down on the compounding and go with "statevector", but I'm not 100% sure about that and can't find the conversation. I've changed all instances in this PR to |
I remember we had a conversation too but couldn't find where we landed with it! I'm good to leave it compounded. |
Continuation of Qiskit#971 > The circuit visualizations are most valuable in the build stage of the circuit. This splits the results visualization into a separate file for the analysis/post-processing stage. Additionally, it makes sense to split the quantum information visualizations into the verify (or learning) step. ### Preview quick links - [analyze/visualize-results](https://qiskit-docs-preview-pr-977.1799mxdls7qz.us-south.codeengine.appdomain.cloud/analyze/visualize-results) - [build-new/circuit-visualization](https://qiskit-docs-preview-pr-977.1799mxdls7qz.us-south.codeengine.appdomain.cloud/build-new/circuit-visualization) - [build-new/plot-quantum-states](https://qiskit-docs-preview-pr-977.1799mxdls7qz.us-south.codeengine.appdomain.cloud/build-new/plot-quantum-states) --------- Co-authored-by: nick bronn <ntbronn@us.ibm.com> Co-authored-by: Kevin J. Sung <kevjsung@umich.edu> Co-authored-by: abbycross <across@us.ibm.com>
PRs Qiskit#977 and Qiskit#1099 added some new pages in anticipation of a restructure which has since been postponed. This PR fits those pages into our current content structure.
Continuation of #971
Preview quick links