Skip to content

Conversation

@frankharkins
Copy link
Member

@frankharkins frankharkins commented Mar 6, 2024

Continuation of #971

The circuit visualizations are most valuable in the build stage of the circuit. This splits the results visualization into a separate file for the analysis/post-processing stage. Additionally, it makes sense to split the quantum information visualizations into the verify (or learning) step.

Preview quick links

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

* Visualizing -> Visualize
* Simplify code
* Format with black
* Lint
* Copy / code edits
* Format with black
* Lint notebook
* Re-run notebook with Qiskit 1.0
* Use tabs to condense information
* Delegate some information to API docs
* Avoid repeating information
Copy link
Collaborator

@abbycross abbycross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job and I love the use of the tabs for the different visualization types! Super cool. I had some lightweight suggestions and also pushed some changes from my local branch - hope that's ok; feel free to revert anything you don't like!

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It'd be helpful to talk about how to visualize results for the Estimator primitive. In Hello World, we use plt.errorbar, but I think @kaelynj and Kevin were saying another type of graph would be more useful.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call, I've had a go at that in Plotting estimator results. I'm gonna get some more reviewers though as my stats knowledge is quite shaky.

Co-authored-by: abbycross <across@us.ibm.com>
@frankharkins
Copy link
Member Author

@abbycross

Oh dear - I see we have both statevector and state vector all throughout our docs, when I do a search! So I don't even know which one to suggest you change to in this PR.... 👀

I think the "correct" term is state vector, but statevector is a common compouding that happens quite a lot within Qiskit (e.g. we called the class Statevector rather than StateVector).

IIRC we discussed this at some point with Jennifer and Becky and decided to double down on the compounding and go with "statevector", but I'm not 100% sure about that and can't find the conversation. I've changed all instances in this PR to statevector for now but we can easily switch back if needed.

@abbycross
Copy link
Collaborator

@abbycross

Oh dear - I see we have both statevector and state vector all throughout our docs, when I do a search! So I don't even know which one to suggest you change to in this PR.... 👀

I think the "correct" term is state vector, but statevector is a common compouding that happens quite a lot within Qiskit (e.g. we called the class Statevector rather than StateVector).

IIRC we discussed this at some point with Jennifer and Becky and decided to double down on the compounding and go with "statevector", but I'm not 100% sure about that and can't find the conversation. I've changed all instances in this PR to statevector for now but we can easily switch back if needed.

I remember we had a conversation too but couldn't find where we landed with it! I'm good to leave it compounded.

@frankharkins frankharkins added this pull request to the merge queue Apr 4, 2024
Merged via the queue into main with commit 0208b5b Apr 4, 2024
@frankharkins frankharkins deleted the FH/split-visualization branch April 4, 2024 13:31
github-merge-queue bot pushed a commit that referenced this pull request Apr 18, 2024
PRs #977 and #1099 added some new pages in anticipation of a restructure
which has since been postponed. This PR fits those pages into our
current content structure.
frankharkins added a commit to frankharkins/documentation that referenced this pull request Jul 22, 2024
Continuation of Qiskit#971

> The circuit visualizations are most valuable in the build stage of the
circuit. This splits the results visualization into a separate file for
the analysis/post-processing stage. Additionally, it makes sense to
split the quantum information visualizations into the verify (or
learning) step.

### Preview quick links

-
[analyze/visualize-results](https://qiskit-docs-preview-pr-977.1799mxdls7qz.us-south.codeengine.appdomain.cloud/analyze/visualize-results)
-
[build-new/circuit-visualization](https://qiskit-docs-preview-pr-977.1799mxdls7qz.us-south.codeengine.appdomain.cloud/build-new/circuit-visualization)
-
[build-new/plot-quantum-states](https://qiskit-docs-preview-pr-977.1799mxdls7qz.us-south.codeengine.appdomain.cloud/build-new/plot-quantum-states)

---------

Co-authored-by: nick bronn <ntbronn@us.ibm.com>
Co-authored-by: Kevin J. Sung <kevjsung@umich.edu>
Co-authored-by: abbycross <across@us.ibm.com>
frankharkins added a commit to frankharkins/documentation that referenced this pull request Jul 22, 2024
PRs Qiskit#977 and Qiskit#1099 added some new pages in anticipation of a restructure
which has since been postponed. This PR fits those pages into our
current content structure.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

5 participants