Use qiskitrc credentials if default config doesn't exist #370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 2539113838
💛 - Coveralls |
kt474
changed the title
|
@rathishcholarajan should be ready for initial review, let me know if this is the implementation we want to go with. |
rathishcholarajan
requested changes
Jun 16, 2022
rathishcholarajan
requested changes
Jun 16, 2022
rathishcholarajan
added
the
Changelog: New Feature
rathishcholarajan
requested changes
Jun 17, 2022
There was a problem hiding this comment.
@kt474 Looks good so far, just remembered that we need to copy these kwargs as well, proxies and verify https://github.com/Qiskit/qiskit-ibmq-provider/blob/master/qiskit/providers/ibmq/ibmqfactory.py#L240
kt474
commented
Jun 20, 2022
rathishcholarajan
requested changes
Jun 20, 2022
rathishcholarajan
requested changes
Jun 21, 2022
rathishcholarajan
approved these changes
Jun 22, 2022
This was referenced Nov 16, 2022
blakejohnson
pushed a commit
to blakejohnson/qiskit-ibm-runtime
that referenced
this pull request
May 26, 2023
* backendv2 name * black * fix variable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
If the
qiskit-ibm.jsonconfig file doesn't exist or doesn't have any valid accounts, credentials will be copied over from aqiskitrcfile, given that it exists.Details and comments
Fixes #301