Move release note in wrong location and add script to block this

.azure/lint-linux.yml

@@ -51,5 +51,6 @@ jobs:
           cargo clippy -- -D warnings
           tools/verify_headers.py qiskit test
           python tools/find_optional_imports.py
+          tools/find_stray_release_notes.py
           reno lint
         displayName: 'Lint'

Makefile

@@ -51,6 +51,7 @@ lint:
 	tools/verify_headers.py qiskit test tools examples
 	pylint -rn --disable='invalid-name, missing-module-docstring, redefined-outer-name' examples/python/*.py
 	tools/find_optional_imports.py
+	tools/find_stray_release_notes.py
 
 # Only pylint on files that have changed from origin/main. Also parallelize (disables cyclic-import check)
 lint-incr:

tools/find_stray_release_notes.py

@@ -0,0 +1,60 @@
+#!/usr/bin/env python3
+# This code is part of Qiskit.
+#
+# (C) Copyright IBM 2022
+#
+# This code is licensed under the Apache License, Version 2.0. You may
+# obtain a copy of this license in the LICENSE.txt file in the root directory
+# of this source tree or at http://www.apache.org/licenses/LICENSE-2.0.
+#
+# Any modifications or derivative works of this code must retain this
+# copyright notice, and modified files need to carry a notice indicating
+# that they have been altered from the originals.
+
+"""Utility script to verify qiskit copyright file headers"""
+
+import argparse
+import multiprocessing
+import subprocess
+import os
+import sys
+import re
+
+# release notes regex
+reno = re.compile(r"releasenotes\/notes")
+# exact release note regex
+exact_reno = re.compile(r"^releasenotes\/notes")
+
+def discover_files():
+    """Find all .py, .pyx, .pxd files in a list of trees"""
+    cmd = ["git", "ls-tree", "-r", "--name-only", "HEAD"]
+    res = subprocess.run(cmd, capture_output=True, check=True, encoding="UTF8")
+    files = res.stdout.split("\n")
+    return files
+
+
+def validate_path(file_path):
+    if reno.search(file_path) and not exact_reno.search(file_path):
+        return file_path
+    return None
+
+
+def _main():
+    default_path = os.path.join(
+        os.path.dirname(os.path.dirname(os.path.abspath(__file__))), "qiskit"
+    )
+    parser = argparse.ArgumentParser(description="Find any stray release notes.")
+    args = parser.parse_args()
+    files = discover_files()
+    with multiprocessing.Pool() as pool:
+        res = pool.map(validate_path, files)
+    failed_files = [x for x in res if x is not None]
+    if len(failed_files) > 0:
+        for failed_file in failed_files:
+            sys.stderr.write("%s is not in the correct location.\n" % failed_file)
+        sys.exit(1)
+    sys.exit(0)
+
+
+if __name__ == "__main__":
+    _main()

tox.ini

@@ -32,6 +32,7 @@ commands =
   # pylint -rn --disable='invalid-name,missing-module-docstring,redefined-outer-name' examples/python/*.py
   {toxinidir}/tools/verify_headers.py qiskit test tools examples
   {toxinidir}/tools/find_optional_imports.py
+  {toxinidir}/tools/find_stray_release_notes.py
   reno lint
 
 [testenv:lint-incr]
@@ -45,6 +46,7 @@ commands =
   {toxinidir}/tools/pylint_incr.py -rn -j4 -sn --disable='invalid-name,missing-module-docstring,redefined-outer-name' --paths :(glob,top)examples/python/*.py
   {toxinidir}/tools/verify_headers.py qiskit test tools examples
   {toxinidir}/tools/find_optional_imports.py
+  {toxinidir}/tools/find_stray_release_notes.py
   reno lint
 
 [testenv:black]