Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: Fix ImportError for gcd #573

Merged
merged 3 commits into from
Mar 1, 2021
Merged

FIX: Fix ImportError for gcd #573

merged 3 commits into from
Mar 1, 2021

Conversation

oyamad
Copy link
Member

@oyamad oyamad commented Mar 1, 2021

fractions.gcd has been switched to math.gcd and is now deprecated in python 3.9.

@mmcky
Copy link
Contributor

mmcky commented Mar 1, 2021

@oyamad I added python=3.9 to the build matrix for tests but looks like some packages we use aren't release for python=3.9 (via pip)?

Perhaps related to numba/llvmlite#669

@oyamad
Copy link
Member Author

oyamad commented Mar 1, 2021

@mmcky Right, numba=0.53 and llvmlite=0.36 have not been released. Their release candidate versions have to be installed manually.

@mmcky
Copy link
Contributor

mmcky commented Mar 1, 2021

@mmcky Right, numba=0.53 and llvmlite=0.36 have not been released. Their release candidate versions have to be installed manually.

@oyamad do you think we should wait until we test against python=3.9 to merge?

@oyamad
Copy link
Member Author

oyamad commented Mar 1, 2021

@mmcky No, you can merge this PR now (reverting the testing against python=3.9). math.gcd has been there since python=3.5.

@mmcky mmcky merged commit e5d5eaa into master Mar 1, 2021
@mmcky mmcky deleted the math_gcd branch March 1, 2021 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants