Add window_background_color config setting #144
Conversation
Also add some minimum effort error checking/correction as this will soon be processing a user-entered value. The extant code path should not be affected as input color values are correctly specified. Color values can be words or hex values. Accepted: - 'black' - 'white' - 'blue' - 'dark blue' - '0x0000ff' Rejected with logged error + exit: - 'nonsense color' - '0xZZZZZZ' Related to: QubesOS/qubes-issues#9304
This configuration setting allows changing the background pixel for local windows that display content of VM windows. Generally the color is only visible rarely and briefly. Previous to this commit the color was hardcoded to white which is suboptimal for users running dark desktop styling. This is the downstream translation of these VM features: - gui-window-background-color - gui-default-window-background-color Testing process: [user@dom0 ~]$ qvm-features dom0 gui-default-window-background-color <color> [user@dom0 ~]$ qvm-run --dispvm=default-dvm --service qubes.StartApp+debian-xterm # (Then play with the terminal's window to expose the color) Related to: QubesOS/qubes-issues#9304
|
Suggestion: If you intend for this PR to fix/close issue QubesOS/qubes-issues#9304 and would like it to be linked to that issue automatically, use: instead of in the PR and/or commit message.
|
Thanks. My hesitation was that there are two pull requests that only jointly resolve the issue. Should one or both have |
|
On Mon, Jun 24, 2024 at 08:52:11AM -0700, Euwiiwueir wrote:
Thanks. My hesitation was that there are two pull requests that only jointly resolve the issue. Should one or both have `Fixes`? Well, I suppose it doesn't matter too much either way.
Better both. This way, both resulting packages will be linked to the
issue.
…--
Best Regards,
Marek Marczykowski-Górecki
Invisible Things Lab
|
|
I think an update should be done for documentation: https://www.qubes-os.org/doc/config-files/ |
I suggest opening an issue for that. |
|
Here is the issue: QubesOS/qubes-issues#9306 |
Note: in QubesOS/qubes-issues#9304 I wrote:
I changed my mind about this in the meantime, I like dark blue, and in this change I allow the setting to be an arbitrary user-selected color. This obligates some error checking around
strtoulandXAllocNamedColor. (An input sanitizing step upstream in memory-safeqvm-features-- QubesOS/qubes-issues#7730 -- would be a good complement.) If the user-selected color is invalid,qubes-guidbails with an error logged to/var/log/qubes/guid.<vm>.log.I think this is ok? But let me know.
Fixes QubesOS/qubes-issues#9304