Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Todo starter unexpected behavior #236

Closed
carsonburr opened this issue Feb 24, 2022 · 1 comment
Closed

Todo starter unexpected behavior #236

carsonburr opened this issue Feb 24, 2022 · 1 comment

Comments

@carsonburr
Copy link

When building and serving the qwik todo starter, the todo check boxes don't behave as expected. Checking off the first box succeeds, but then clicking the second box leaves the text without the strikethrough and leaves the checkbox image in the unchecked state. This only occurs when building and then serving. It doesn't occur when running in dev mode.

npm version: 8.4.1
node version: 16.13.2
browser: chromium 98
os: linux

steps to reproduce:
1.

$ npm init qwik@latest # todo -> express
$ cd qwik-app
$ npm install
$ npm run build
$ npm run serve
  1. click the first checkbox
  2. click the second checkbox

other notes:
I dug into this a bit and it looks like there are 2 instances of the qwik loader script, which both try to handle the click event. One qwik loader gets inlined with the initial html, the other lazily imported after the first event is triggered. I think this is causing the item.completed to be toggled twice each click.

@manucorporat
Copy link
Contributor

Fixed by #261

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants