From 85022108419e0eae8aa5581f80e8904c892d52a4 Mon Sep 17 00:00:00 2001 From: Thomas Deinhamer <184284+thasmo@users.noreply.github.com> Date: Tue, 14 Nov 2023 21:03:47 +0100 Subject: [PATCH] Wrap function in cleanup function instead of returning it --- .../src/routes/tutorial/events/synchronous/solution/app.tsx | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/docs/src/routes/tutorial/events/synchronous/solution/app.tsx b/packages/docs/src/routes/tutorial/events/synchronous/solution/app.tsx index 4d95cbe80c4..34a95852ea8 100644 --- a/packages/docs/src/routes/tutorial/events/synchronous/solution/app.tsx +++ b/packages/docs/src/routes/tutorial/events/synchronous/solution/app.tsx @@ -2,13 +2,13 @@ import { component$, useVisibleTask$, useSignal } from '@builder.io/qwik'; export default component$(() => { const aHref = useSignal(); - useVisibleTask$(() => { + useVisibleTask$(({cleanup}) => { const handler = (event: Event) => { event.preventDefault(); window.open('http://qwik.builder.io'); }; aHref.value!.addEventListener('click', handler); - return () => aHref.value!.removeEventListener('click', handler); + cleanup(() => aHref.value!.removeEventListener('click', handler)); }); return (