-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: mark event listeners inside loops as var props #7056
base: build/v2
Are you sure you want to change the base?
Conversation
|
7953394
to
02ccb50
Compare
commit: |
built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
|
so my reservation is that if this is needed, we may need it always. constProps are fixed references to possibly mutable objects. Maybe we should only mark deeply const props as constProps |
02ccb50
to
b81a91a
Compare
b81a91a
to
03d517a
Compare
If event handler is changing should be inside var props, because const props are ignored by vnodes. This is a case when we iterate over an items and return a jsx with an event listener.
closes #7032