Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

new_constructor() drops properties that have a getter, even if they have a setter #421

Closed
lawremi opened this issue Aug 21, 2024 · 1 comment
Closed

new_constructor() drops properties that have a getter, even if they have a setter #421

lawremi opened this issue Aug 21, 2024 · 1 comment

Comments

@lawremi
Copy link
Collaborator

lawremi commented Aug 21, 2024

See this line:

79557c0#diff-4b9b805aa09ee8da593ca9764b00b50a94ac6e0e1e4483ca63cfcb523acce9c9R58

My understanding is that a property is only read-only if it has a getter but not a setter. Perhaps it would be worth defining a prop_is_read_only() function?
lawremi added a commit that referenced this issue Aug 21, 2024
@lawremi
call prop_is_read_only() as appropriate; fixes #421
4c0234d
@lawremi lawremi mentioned this issue Aug 21, 2024
Closed
lawremi added a commit that referenced this issue Aug 23, 2024
@lawremi
call prop_is_read_only() as appropriate; fixes #421
d795f74
lawremi added a commit that referenced this issue Aug 24, 2024
@lawremi
call prop_is_read_only() as appropriate; fixes #421
86d2a4a
lawremi added a commit that referenced this issue Aug 26, 2024
@lawremi
call prop_is_read_only() as appropriate; fixes #421
cf2bc4b
lawremi added a commit to lawremi/S7 that referenced this issue Sep 6, 2024
@lawremi
call prop_is_read_only() as appropriate; fixes RConsortium#421
1bdc3c6
@t-kalinowski
Copy link
Member

Fixed in #445

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lawremi @t-kalinowski