Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validation improvements #149

Merged
merged 11 commits into from
Feb 10, 2022
Merged

Validation improvements #149

merged 11 commits into from
Feb 10, 2022

Commits on Feb 7, 2022

  1. Error when setting unknown properties

    @hadley
    hadley committed Feb 7, 2022
    Configuration menu
    Copy the full SHA
    5b99ad5 View commit details
    Browse the repository at this point in the history

  2. Validate recursively & validate properties 

    And improve docs
    @hadley
    hadley committed Feb 7, 2022
    Configuration menu
    Copy the full SHA
    f159ca0 View commit details
    Browse the repository at this point in the history

Commits on Feb 8, 2022

  1. Remove manual validation suppression 

    And add test
    @hadley
    hadley committed Feb 8, 2022
    Configuration menu
    Copy the full SHA
    a2ab6b7 View commit details
    Browse the repository at this point in the history

  2. Move parent checking out of constructor and into validator

    @hadley
    hadley committed Feb 8, 2022
    Configuration menu
    Copy the full SHA
    f2b2957 View commit details
    Browse the repository at this point in the history

  3. Add news bullet

    @hadley
    hadley committed Feb 8, 2022
    Configuration menu
    Copy the full SHA
    28c4941 View commit details
    Browse the repository at this point in the history

  4. Test that base types are validated

    @hadley
    hadley committed Feb 8, 2022
    Configuration menu
    Copy the full SHA
    2105da1 View commit details
    Browse the repository at this point in the history

  5. Implement props<-

    @hadley
    hadley committed Feb 8, 2022
    Configuration menu
    Copy the full SHA
    268e9d8 View commit details
    Browse the repository at this point in the history

Commits on Feb 10, 2022

  1. Feedback from review

    @hadley
    hadley committed Feb 10, 2022
    Configuration menu
    Copy the full SHA
    b000121 View commit details
    Browse the repository at this point in the history

  2. Apply suggestions from code review 

    Co-authored-by: Davis Vaughan <davis@rstudio.com>
    @hadley @DavisVaughan
    hadley and DavisVaughan authored Feb 10, 2022
    Configuration menu
    Copy the full SHA
    2bd44d5 View commit details
    Browse the repository at this point in the history

  3. Merged origin/validation-improvements into validation-improvements

    @hadley
    hadley committed Feb 10, 2022
    Configuration menu
    Copy the full SHA
    f36abf1 View commit details
    Browse the repository at this point in the history

  4. Re-document

    @hadley
    hadley committed Feb 10, 2022
    Configuration menu
    Copy the full SHA
    f1afc91 View commit details
    Browse the repository at this point in the history