Skip to content

sys/include: use SPDX license tags #21908

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 16 commits into
base: master
Choose a base branch
from
Open

sys/include: use SPDX license tags #21908

wants to merge 16 commits into from
+1,294 −3,267

Conversation

@maribu
Copy link
Member

@maribu maribu commented Nov 23, 2025

Contribution description

As the title says

Testing procedure

The CI should run super fast if it can determine that changes are whitespace only. This should be the case here.

In addition, the diff should be checked for correctness.

Issues/PRs references

#21515

@github-actions github-actions bot added Area: network Area: Networking Area: doc Area: Documentation Area: BLE Area: Bluetooth Low Energy support Area: timers Area: timer subsystems Area: LoRa Area: LoRa radio support Area: SAUL Area: Sensor/Actuator Uber Layer Area: OTA Area: Over-the-air updates Area: CoAP Area: Constrained Application Protocol implementations Area: USB Area: Universal Serial Bus Area: sys Area: System labels Nov 23, 2025
@maribu maribu changed the title LICENSES: Add BSD-2-Clause license sys/include: use SPDX license tags Nov 23, 2025
@maribu maribu added Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed Area: network Area: Networking Area: doc Area: Documentation Area: BLE Area: Bluetooth Low Energy support Area: timers Area: timer subsystems Area: LoRa Area: LoRa radio support Area: SAUL Area: Sensor/Actuator Uber Layer Area: OTA Area: Over-the-air updates Area: CoAP Area: Constrained Application Protocol implementations Area: USB Area: Universal Serial Bus Area: sys Area: System labels Nov 23, 2025
@riot-ci
Copy link

riot-ci commented Nov 23, 2025 •
edited
Loading

Murdock results

✔️ PASSED

feb51e5 Update sys/include/net/gnrc/pktqueue.h

Success Failures Total Runtime
1 0 1 01m:51s

Artifacts

crasbe
crasbe requested changes Nov 23, 2025
View reviewed changes
Copy link
Contributor

@crasbe crasbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please try to keep these PRs <200 files. The Github performance goes down exponentially and the last 50 or so files weren't loaded, I had to manually click the "Load diff" button and it takes like 5-10s each time. Adding a comment takes about 30s, so yeah...

sys/include/crypto/chacha.h
Copy link
Contributor

@crasbe crasbe Nov 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How do we handle a "dedicated to the public domain" case? I remember this "PD is not a license" discussion, but should we add that to the License Identifier or something? Or just leave the note?

Copy link
Member Author

@maribu maribu Nov 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We cannot add it to the license identifier, as PD is not a license 🤣

sys/include/crypto/poly1305.h
Copy link
Contributor

@crasbe crasbe Nov 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here.

@maribu @crasbe
Update sys/include/benchmark.h
6f6a817 
Co-authored-by: crasbe <crasbe@gmail.com>
@github-actions github-actions bot added Area: network Area: Networking Area: doc Area: Documentation Area: BLE Area: Bluetooth Low Energy support Area: timers Area: timer subsystems Area: LoRa Area: LoRa radio support Area: SAUL Area: Sensor/Actuator Uber Layer Area: OTA Area: Over-the-air updates Area: CoAP Area: Constrained Application Protocol implementations Area: USB Area: Universal Serial Bus Area: sys Area: System labels Nov 24, 2025
maribu and others added 11 commits November 24, 2025 17:34
@maribu @crasbe
Update sys/include/evtimer.h
3902961 
Co-authored-by: crasbe <crasbe@gmail.com>
@maribu @crasbe
Update sys/include/net/gnrc/rpl.h
e146622 
Co-authored-by: crasbe <crasbe@gmail.com>
@maribu @crasbe
Update sys/include/net/gnrc/rpl/dodag.h
504048b 
Co-authored-by: crasbe <crasbe@gmail.com>
@maribu @crasbe
Update sys/include/net/gnrc/rpl/structs.h
00df44e 
Co-authored-by: crasbe <crasbe@gmail.com>
@maribu @crasbe
Update sys/include/trace.h
2006023 
Co-authored-by: crasbe <crasbe@gmail.com>
@maribu @crasbe
Update sys/include/trickle.h
272a851 
Co-authored-by: crasbe <crasbe@gmail.com>
@maribu @crasbe
Update sys/include/evtimer_msg.h
1800513 
Co-authored-by: crasbe <crasbe@gmail.com>
@maribu @crasbe
Update sys/include/net/bluetil/ad.h
038b4b0 
Co-authored-by: crasbe <crasbe@gmail.com>
@maribu @crasbe
Update sys/include/net/cord/common.h
faf4ec4 
Co-authored-by: crasbe <crasbe@gmail.com>
@maribu @crasbe
Update sys/include/net/gnrc/pkt.h
3f24476 
Co-authored-by: crasbe <crasbe@gmail.com>
@maribu @crasbe
Update sys/include/net/gnrc/pktqueue.h
feb51e5 
Co-authored-by: crasbe <crasbe@gmail.com>
AnnsAnns
AnnsAnns reviewed Nov 27, 2025
View reviewed changes
Copy link
Member

@AnnsAnns AnnsAnns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kinda surprising how many licenses are in here, mostly agree with all points raised by crasbe 👍

sys/include/hashes/sha224.h
* OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
* SUCH DAMAGE.
*
* $FreeBSD: src/lib/libmd/sha256.h,v 1.1.2.1 2005/06/24 13:32:25 cperciva Exp $
Copy link
Member

@AnnsAnns AnnsAnns Nov 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed

sys/include/hashes/sha256.h
* OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
* SUCH DAMAGE.
*
* $FreeBSD: src/lib/libmd/sha256.h,v 1.1.2.1 2005/06/24 13:32:25 cperciva Exp $
Copy link
Member

@AnnsAnns AnnsAnns Nov 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

here too

sys/include/hashes/sha2xx_common.h
* OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
* SUCH DAMAGE.
*
* $FreeBSD: src/lib/libmd/sha256.h,v 1.1.2.1 2005/06/24 13:32:25 cperciva Exp $
Copy link
Member

@AnnsAnns AnnsAnns Nov 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

here too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AnnsAnns AnnsAnns AnnsAnns left review comments

@crasbe crasbe crasbe requested changes

@kaspar030 kaspar030 Awaiting requested review from kaspar030 kaspar030 is a code owner

@bergzand bergzand Awaiting requested review from bergzand bergzand is a code owner

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

Area: BLE Area: Bluetooth Low Energy support Area: CoAP Area: Constrained Application Protocol implementations Area: doc Area: Documentation Area: LoRa Area: LoRa radio support Area: network Area: Networking Area: OTA Area: Over-the-air updates Area: SAUL Area: Sensor/Actuator Uber Layer Area: sys Area: System Area: timers Area: timer subsystems Area: USB Area: Universal Serial Bus CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@maribu @riot-ci @crasbe @AnnsAnns