-
Notifications
You must be signed in to change notification settings - Fork 6
Addressed several issues found in the sim2sim tutorial after the recent Isaac Lab version update. #10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
kimtaehyeong99
commented
Nov 11, 2025
- Updated record and replay scripts in robotis_lab to ensure compatibility with the latest Isaac Lab version.
- Added exception handling to prevent runtime errors during data recording.
- Tuned robot physical parameters (effort, stiffness, damping) for more stable simulation behavior.
…mproved functionality and clarity
Summary of ChangesHello @kimtaehyeong99, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses critical compatibility and stability issues within the sim2sim tutorial following a recent Isaac Lab version update. It ensures that the demonstration recording and replaying functionalities work seamlessly, enhances the robustness of data processing by introducing exception handling, and refines the physical parameters of the simulated robots for improved stability and realism. These changes collectively aim to provide a more reliable and accurate simulation environment for robotics research and development. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request significantly updates the sim2sim tutorial for Isaac Lab, ensuring compatibility with the latest version. Key improvements include enhanced error handling in data recording and processing, refined robot physical parameters for more stable simulation, and clearer documentation for users. The changes streamline the recording and replay scripts, integrate new XR visualization features, and adjust environment configurations for better task performance and realism.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the sim2sim tutorial code to be compatible with the latest Isaac Lab version. The changes include API updates for device interfaces, robot configuration refactoring, physical parameter tuning, exception handling improvements, and path corrections for the robot hierarchy.
- Refactored robot configurations by removing separate "high PD" configurations and consolidating into single base configurations with updated physical parameters
- Updated Isaac Lab device API usage (Se3Keyboard now requires Se3KeyboardCfg)
- Added exception handling to data recording and conversion scripts to prevent runtime errors
- Corrected robot hierarchy paths in FFW_BG2 configurations to match updated USD file structure
Reviewed Changes
Copilot reviewed 15 out of 16 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| source/robotis_lab/robotis_lab/simulation_tasks/manager_based/OMY/stack/joint_pos_env_cfg.py | Updated default joint pose and object spawn range for stack task |
| source/robotis_lab/robotis_lab/simulation_tasks/manager_based/OMY/stack/ik_rel_env_cfg.py | Increased IK action scale from 0.1 to 0.15 |
| source/robotis_lab/robotis_lab/simulation_tasks/manager_based/OMY/lift/joint_pos_env_cfg.py | Switched from OMY_HIGH_PD_CFG to OMY_CFG |
| source/robotis_lab/robotis_lab/simulation_tasks/manager_based/OMY/lift/ik_rel_env_cfg.py | Switched from OMY_HIGH_PD_CFG to OMY_CFG |
| source/robotis_lab/robotis_lab/simulation_tasks/manager_based/FFW_BG2/pick_place/pick_place_env_cfg.py | Updated table position, added object position/rotation observations |
| source/robotis_lab/robotis_lab/simulation_tasks/manager_based/FFW_BG2/pick_place/joint_pos_env_cfg.py | Refactored events, updated robot config, corrected camera/frame paths |
| source/robotis_lab/robotis_lab/simulation_tasks/manager_based/FFW_BG2/pick_place/ik_rel_env_cfg.py | Switched from FFW_BG2_PICK_PLACE_CFG to FFW_BG2_CFG |
| source/robotis_lab/robotis_lab/assets/robots/OMY.py | Removed OMY_HIGH_PD_CFG, tuned damping/stiffness parameters, expanded gripper joint control |
| source/robotis_lab/robotis_lab/assets/robots/FFW_BG2.py | Removed FFW_BG2_PICK_PLACE_CFG, tuned actuator parameters for grippers and head |
| scripts/sim2real/imitation_learning/recorder/record_demos.py | Added handling for dictionary actions with reset keys |
| scripts/sim2real/imitation_learning/mimic/action_data_converter.py | Added exception handling and error reporting for episode processing |
| scripts/sim2real/imitation_learning/dds_sdk/omy_sdk.py | Updated device state retrieval to use current robot joint positions |
| scripts/imitation_learning/isaaclab_recorder/replay_demos.py | Updated Se3Keyboard API to use Se3KeyboardCfg, added locomanipulation task import |
| scripts/imitation_learning/isaaclab_recorder/record_demos.py | Updated argparse help text, fixed parameter passing, added XR visualization setup, reordered demo completion check |
| README.md | Corrected script path and added reference to physical_ai_tools |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
.../robotis_lab/robotis_lab/simulation_tasks/manager_based/FFW_BG2/pick_place/ik_rel_env_cfg.py
Outdated
Show resolved
Hide resolved
source/robotis_lab/robotis_lab/simulation_tasks/manager_based/OMY/lift/ik_rel_env_cfg.py
Outdated
Show resolved
Hide resolved
…OMY/lift/ik_rel_env_cfg.py Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Taehyeong Kim <155407023+kimtaehyeong99@users.noreply.github.com>
…FFW_BG2/pick_place/ik_rel_env_cfg.py Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Taehyeong Kim <155407023+kimtaehyeong99@users.noreply.github.com>
GyuH13
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
GOOD. Now it is syncronized with isaac lab.
ola31
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good