Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rocSparse no longer builds #18

Open
VileLasagna opened this issue May 7, 2019 · 4 comments
Open

rocSparse no longer builds #18

VileLasagna opened this issue May 7, 2019 · 4 comments

Comments

@VileLasagna
Copy link

During the support/utility libraries build, 03_04 is rocSPARSE.
Right now this isn't building any more and after digging a bit I've found out why:

Though the pull headers for all of the software directly built are specified on common_options.sh, some of those depend on other software.

On the build for rocSPARSE, it looks for hipCUB and rocPRIM and, if it can't find them, acquires and builds them through CMake. This is where the issue happens.
rocPRIM gets cloned from master but it got updated a while back and hipCUB got removed from it, now being an entirely separate repository. rocSPARSE was not updated to reflect this (even in current master/develop) so that it cannot build it any more.

Currently I'm working in porting the scripts to yet another distro that I intend to open a PR for, this time OpenSuSE Leap15 (it's going to be fun when in like a month I need to go back for 15.1) and intend to fix this on that one, as well as go back to my Arch Linux branch and apply a similar fix.

The fix I'll implement is creating a 03_04_hipCUB.sh that installs both it and rocPRIM, and then bump the "step number" for each subsequent library.

Until rocSPARSE gets fixed, I believe a similar solution might be necessary for the officially supported distros.

@VileLasagna
Copy link
Author

UPDATE: hipCUB itself seems to be different from what used to be in rocPRIM. As such I ended up fixing the issue by building rocPRIM's 2.3 tag instead

@lucianolorenti
Copy link

lucianolorenti commented May 11, 2019

VileLasagna I am using your branch to build ROC on archlinux. I am having this issue with hipCUB. Can you explain a bit more about how you fix it?

Did you change the GIT_TAG of to rocPRIM 2.3 in rocALUTION cmake/Dependencies.cmake ?

@VileLasagna
Copy link
Author

VileLasagna commented May 11, 2019 via email

@VileLasagna
Copy link
Author

Okay, the fix should be up on my branch. Did a quick build of that and rocsparse and it seemed to go well, but my system isn't exactly clean so let me know if something needs cleaning.

The fix was as follows:
I've added a 03_04_rocprim.sh script and incremented the following ones (correcting 03_src_install_rocm_libraries.sh)
The script builds rocprim from the tag 2.3. The TAG parameter is local to that script as I didn't want this change to "leak back" into the common_options script, where all the other tags are

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants