Update dev docker docs to remove old content #769
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rohan138
requested review from
gshtras,
hongxiayang,
maleksan85,
shajrawi and
sunway513
as code owners
gshtras
reviewed
Oct 31, 2025
| git checkout aiter_integration_final | ||
| docker build -f docker/Dockerfile.rocm -t <your_tag> --build-arg USE_CYTHON=1 . | ||
| ``` | ||
| For instructions on how to build a vLLM docker image, see https://docs.vllm.ai/en/latest/getting_started/installation/gpu.html#build-image-from-source |
There was a problem hiding this comment.
The doc tells you how to build the main branch. Here it's better to mention the difference in building the release branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update dev-docker document to only contain updated+neccessary information to rpeorduce the performance benchmarks at https://www.amd.com/en/developer/resources/rocm-hub/dev-ai/performance-results.html#tabs-a8deaeb413-item-c7e463a3c3-tab
Purpose
Test Plan
Test Result
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.